Commit b5fbf924 authored by Dan Carpenter's avatar Dan Carpenter Committed by Thomas Zimmermann

drm/client: Fix error code in drm_client_buffer_vmap_local()

This function accidentally returns zero/success on the failure path.
It leads to locking issues and an uninitialized *map_copy in the
caller.

Fixes: b4b0193e ("drm/fbdev-generic: Fix locking with drm_client_buffer_vmap_local()")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: default avatarDmitry Osipenko <dmitry.osipenko@collabora.com>
Reviewed-by: default avatarThomas Zimmermann <tzimmermann@suse.de>
Signed-off-by: default avatarThomas Zimmermann <tzimmermann@suse.de>
Link: https://patchwork.freedesktop.org/patch/msgid/89d13df3-747c-4c5d-b122-d081aef5110a@stanley.mountain
parent 75c3e8a2
...@@ -355,7 +355,7 @@ int drm_client_buffer_vmap_local(struct drm_client_buffer *buffer, ...@@ -355,7 +355,7 @@ int drm_client_buffer_vmap_local(struct drm_client_buffer *buffer,
err_drm_gem_vmap_unlocked: err_drm_gem_vmap_unlocked:
drm_gem_unlock(gem); drm_gem_unlock(gem);
return 0; return ret;
} }
EXPORT_SYMBOL(drm_client_buffer_vmap_local); EXPORT_SYMBOL(drm_client_buffer_vmap_local);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment