Commit b75dacaa authored by Yucong Sun's avatar Yucong Sun Committed by Andrii Nakryiko

selftests/bpf: Fix crash in core_reloc when bpftool btfgen fails

Avoid unnecessary goto cleanup, as there is nothing to clean up.
Signed-off-by: default avatarYucong Sun <fallentree@fb.com>
Signed-off-by: default avatarAndrii Nakryiko <andrii@kernel.org>
Link: https://lore.kernel.org/bpf/20220217180210.2981502-1-fallentree@fb.com
parent b38101c5
...@@ -888,12 +888,12 @@ static void run_core_reloc_tests(bool use_btfgen) ...@@ -888,12 +888,12 @@ static void run_core_reloc_tests(bool use_btfgen)
fd = mkstemp(btf_file); fd = mkstemp(btf_file);
if (!ASSERT_GE(fd, 0, "btf_tmp")) if (!ASSERT_GE(fd, 0, "btf_tmp"))
goto cleanup; continue;
close(fd); /* we only need the path */ close(fd); /* we only need the path */
err = run_btfgen(test_case->btf_src_file, btf_file, err = run_btfgen(test_case->btf_src_file, btf_file,
test_case->bpf_obj_file); test_case->bpf_obj_file);
if (!ASSERT_OK(err, "run_btfgen")) if (!ASSERT_OK(err, "run_btfgen"))
goto cleanup; continue;
test_case->btf_src_file = btf_file; test_case->btf_src_file = btf_file;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment