Commit b78d0fa2 authored by Dawei Li's avatar Dawei Li Committed by Will Deacon

perf/hisi_uncore: Avoid placing cpumask on the stack

In general it's preferable to avoid placing cpumasks on the stack, as
for large values of NR_CPUS these can consume significant amounts of
stack space and make stack overflows more likely.

Use cpumask_any_and_but() to avoid the need for a temporary cpumask on
the stack.
Suggested-by: default avatarMark Rutland <mark.rutland@arm.com>
Reviewed-by: default avatarMark Rutland <mark.rutland@arm.com>
Signed-off-by: default avatarDawei Li <dawei.li@shingroup.cn>
Acked-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
Link: https://lore.kernel.org/r/20240403155950.2068109-9-dawei.li@shingroup.cnSigned-off-by: default avatarWill Deacon <will@kernel.org>
parent d7df79e6
...@@ -504,7 +504,6 @@ int hisi_uncore_pmu_offline_cpu(unsigned int cpu, struct hlist_node *node) ...@@ -504,7 +504,6 @@ int hisi_uncore_pmu_offline_cpu(unsigned int cpu, struct hlist_node *node)
{ {
struct hisi_pmu *hisi_pmu = hlist_entry_safe(node, struct hisi_pmu, struct hisi_pmu *hisi_pmu = hlist_entry_safe(node, struct hisi_pmu,
node); node);
cpumask_t pmu_online_cpus;
unsigned int target; unsigned int target;
if (!cpumask_test_and_clear_cpu(cpu, &hisi_pmu->associated_cpus)) if (!cpumask_test_and_clear_cpu(cpu, &hisi_pmu->associated_cpus))
...@@ -518,9 +517,8 @@ int hisi_uncore_pmu_offline_cpu(unsigned int cpu, struct hlist_node *node) ...@@ -518,9 +517,8 @@ int hisi_uncore_pmu_offline_cpu(unsigned int cpu, struct hlist_node *node)
hisi_pmu->on_cpu = -1; hisi_pmu->on_cpu = -1;
/* Choose a new CPU to migrate ownership of the PMU to */ /* Choose a new CPU to migrate ownership of the PMU to */
cpumask_and(&pmu_online_cpus, &hisi_pmu->associated_cpus, target = cpumask_any_and_but(&hisi_pmu->associated_cpus,
cpu_online_mask); cpu_online_mask, cpu);
target = cpumask_any_but(&pmu_online_cpus, cpu);
if (target >= nr_cpu_ids) if (target >= nr_cpu_ids)
return 0; return 0;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment