Commit b7ab0b19 authored by Hefty, Sean's avatar Hefty, Sean Committed by Roland Dreier

IB/mad: Verify mgmt class in received MADs

If a received MAD contains an invalid or reserved mgmt class, we will
attempt to access method_table outside of its range.  Add a check to
ensure that mgmt class falls within the handled range.

Found by code inspection.
Signed-off-by: default avatarSean Hefty <sean.hefty@intel.com>
Signed-off-by: default avatarRoland Dreier <roland@purestorage.com>
parent f45ee80e
...@@ -1596,6 +1596,9 @@ find_mad_agent(struct ib_mad_port_private *port_priv, ...@@ -1596,6 +1596,9 @@ find_mad_agent(struct ib_mad_port_private *port_priv,
mad->mad_hdr.class_version].class; mad->mad_hdr.class_version].class;
if (!class) if (!class)
goto out; goto out;
if (convert_mgmt_class(mad->mad_hdr.mgmt_class) >=
IB_MGMT_MAX_METHODS)
goto out;
method = class->method_table[convert_mgmt_class( method = class->method_table[convert_mgmt_class(
mad->mad_hdr.mgmt_class)]; mad->mad_hdr.mgmt_class)];
if (method) if (method)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment