Commit b7b361f0 authored by Julia Lawall's avatar Julia Lawall Committed by Mauro Carvalho Chehab

[media] platform: constify vb2_ops structures

Check for vb2_ops structures that are only stored in the ops field of a
vb2_queue structure.  That field is declared const, so vb2_ops structures
that have this property can be declared as const also.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@r disable optional_qualifier@
identifier i;
position p;
@@
static struct vb2_ops i@p = { ... };

@ok@
identifier r.i;
struct vb2_queue e;
position p;
@@
e.ops = &i@p;

@bad@
position p != {r.p,ok.p};
identifier r.i;
struct vb2_ops e;
@@
e@i@p

@depends on !bad disable optional_qualifier@
identifier r.i;
@@
static
+const
 struct vb2_ops i = { ... };
// </smpl>
Signed-off-by: default avatarJulia Lawall <Julia.Lawall@lip6.fr>
Reviewed-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: default avatarFabien Dessenne <fabien.dessenne@st.com>
Reviewed-by: default avatarJacek Anaszewski <j.anaszewski@samsung.com>
Reviewed-by: default avatarBenoit Parrot <bparrot@ti.com>
[hans.verkuil@cisco.com: dropped soc_camera/rcar_vin.c patch because that driver will be removed]
Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
parent 1bc17717
...@@ -261,7 +261,7 @@ static void gsc_m2m_buf_queue(struct vb2_buffer *vb) ...@@ -261,7 +261,7 @@ static void gsc_m2m_buf_queue(struct vb2_buffer *vb)
v4l2_m2m_buf_queue(ctx->m2m_ctx, vbuf); v4l2_m2m_buf_queue(ctx->m2m_ctx, vbuf);
} }
static struct vb2_ops gsc_m2m_qops = { static const struct vb2_ops gsc_m2m_qops = {
.queue_setup = gsc_m2m_queue_setup, .queue_setup = gsc_m2m_queue_setup,
.buf_prepare = gsc_m2m_buf_prepare, .buf_prepare = gsc_m2m_buf_prepare,
.buf_queue = gsc_m2m_buf_queue, .buf_queue = gsc_m2m_buf_queue,
......
...@@ -452,7 +452,7 @@ static void buffer_queue(struct vb2_buffer *vb) ...@@ -452,7 +452,7 @@ static void buffer_queue(struct vb2_buffer *vb)
spin_unlock_irqrestore(&fimc->slock, flags); spin_unlock_irqrestore(&fimc->slock, flags);
} }
static struct vb2_ops fimc_capture_qops = { static const struct vb2_ops fimc_capture_qops = {
.queue_setup = queue_setup, .queue_setup = queue_setup,
.buf_prepare = buffer_prepare, .buf_prepare = buffer_prepare,
.buf_queue = buffer_queue, .buf_queue = buffer_queue,
......
...@@ -219,7 +219,7 @@ static void fimc_buf_queue(struct vb2_buffer *vb) ...@@ -219,7 +219,7 @@ static void fimc_buf_queue(struct vb2_buffer *vb)
v4l2_m2m_buf_queue(ctx->fh.m2m_ctx, vbuf); v4l2_m2m_buf_queue(ctx->fh.m2m_ctx, vbuf);
} }
static struct vb2_ops fimc_qops = { static const struct vb2_ops fimc_qops = {
.queue_setup = fimc_queue_setup, .queue_setup = fimc_queue_setup,
.buf_prepare = fimc_buf_prepare, .buf_prepare = fimc_buf_prepare,
.buf_queue = fimc_buf_queue, .buf_queue = fimc_buf_queue,
......
...@@ -852,7 +852,7 @@ static void deinterlace_buf_queue(struct vb2_buffer *vb) ...@@ -852,7 +852,7 @@ static void deinterlace_buf_queue(struct vb2_buffer *vb)
v4l2_m2m_buf_queue(ctx->m2m_ctx, vbuf); v4l2_m2m_buf_queue(ctx->m2m_ctx, vbuf);
} }
static struct vb2_ops deinterlace_qops = { static const struct vb2_ops deinterlace_qops = {
.queue_setup = deinterlace_queue_setup, .queue_setup = deinterlace_queue_setup,
.buf_prepare = deinterlace_buf_prepare, .buf_prepare = deinterlace_buf_prepare,
.buf_queue = deinterlace_buf_queue, .buf_queue = deinterlace_buf_queue,
......
...@@ -933,7 +933,7 @@ static void vb2ops_venc_stop_streaming(struct vb2_queue *q) ...@@ -933,7 +933,7 @@ static void vb2ops_venc_stop_streaming(struct vb2_queue *q)
ctx->state = MTK_STATE_FREE; ctx->state = MTK_STATE_FREE;
} }
static struct vb2_ops mtk_venc_vb2_ops = { static const struct vb2_ops mtk_venc_vb2_ops = {
.queue_setup = vb2ops_venc_queue_setup, .queue_setup = vb2ops_venc_queue_setup,
.buf_prepare = vb2ops_venc_buf_prepare, .buf_prepare = vb2ops_venc_buf_prepare,
.buf_queue = vb2ops_venc_buf_queue, .buf_queue = vb2ops_venc_buf_queue,
......
...@@ -743,7 +743,7 @@ static void emmaprp_buf_queue(struct vb2_buffer *vb) ...@@ -743,7 +743,7 @@ static void emmaprp_buf_queue(struct vb2_buffer *vb)
v4l2_m2m_buf_queue(ctx->m2m_ctx, vbuf); v4l2_m2m_buf_queue(ctx->m2m_ctx, vbuf);
} }
static struct vb2_ops emmaprp_qops = { static const struct vb2_ops emmaprp_qops = {
.queue_setup = emmaprp_queue_setup, .queue_setup = emmaprp_queue_setup,
.buf_prepare = emmaprp_buf_prepare, .buf_prepare = emmaprp_buf_prepare,
.buf_queue = emmaprp_buf_queue, .buf_queue = emmaprp_buf_queue,
......
...@@ -1114,7 +1114,7 @@ static void rvin_stop_streaming(struct vb2_queue *vq) ...@@ -1114,7 +1114,7 @@ static void rvin_stop_streaming(struct vb2_queue *vq)
rvin_disable_interrupts(vin); rvin_disable_interrupts(vin);
} }
static struct vb2_ops rvin_qops = { static const struct vb2_ops rvin_qops = {
.queue_setup = rvin_queue_setup, .queue_setup = rvin_queue_setup,
.buf_prepare = rvin_buffer_prepare, .buf_prepare = rvin_buffer_prepare,
.buf_queue = rvin_buffer_queue, .buf_queue = rvin_buffer_queue,
......
...@@ -1183,7 +1183,7 @@ static void jpu_stop_streaming(struct vb2_queue *vq) ...@@ -1183,7 +1183,7 @@ static void jpu_stop_streaming(struct vb2_queue *vq)
} }
} }
static struct vb2_ops jpu_qops = { static const struct vb2_ops jpu_qops = {
.queue_setup = jpu_queue_setup, .queue_setup = jpu_queue_setup,
.buf_prepare = jpu_buf_prepare, .buf_prepare = jpu_buf_prepare,
.buf_queue = jpu_buf_queue, .buf_queue = jpu_buf_queue,
......
...@@ -138,7 +138,7 @@ static void g2d_buf_queue(struct vb2_buffer *vb) ...@@ -138,7 +138,7 @@ static void g2d_buf_queue(struct vb2_buffer *vb)
v4l2_m2m_buf_queue(ctx->fh.m2m_ctx, vbuf); v4l2_m2m_buf_queue(ctx->fh.m2m_ctx, vbuf);
} }
static struct vb2_ops g2d_qops = { static const struct vb2_ops g2d_qops = {
.queue_setup = g2d_queue_setup, .queue_setup = g2d_queue_setup,
.buf_prepare = g2d_buf_prepare, .buf_prepare = g2d_buf_prepare,
.buf_queue = g2d_buf_queue, .buf_queue = g2d_buf_queue,
......
...@@ -2545,7 +2545,7 @@ static void s5p_jpeg_stop_streaming(struct vb2_queue *q) ...@@ -2545,7 +2545,7 @@ static void s5p_jpeg_stop_streaming(struct vb2_queue *q)
pm_runtime_put(ctx->jpeg->dev); pm_runtime_put(ctx->jpeg->dev);
} }
static struct vb2_ops s5p_jpeg_qops = { static const struct vb2_ops s5p_jpeg_qops = {
.queue_setup = s5p_jpeg_queue_setup, .queue_setup = s5p_jpeg_queue_setup,
.buf_prepare = s5p_jpeg_buf_prepare, .buf_prepare = s5p_jpeg_buf_prepare,
.buf_queue = s5p_jpeg_buf_queue, .buf_queue = s5p_jpeg_buf_queue,
......
...@@ -362,7 +362,7 @@ static void sh_vou_stop_streaming(struct vb2_queue *vq) ...@@ -362,7 +362,7 @@ static void sh_vou_stop_streaming(struct vb2_queue *vq)
spin_unlock_irqrestore(&vou_dev->lock, flags); spin_unlock_irqrestore(&vou_dev->lock, flags);
} }
static struct vb2_ops sh_vou_qops = { static const struct vb2_ops sh_vou_qops = {
.queue_setup = sh_vou_queue_setup, .queue_setup = sh_vou_queue_setup,
.buf_prepare = sh_vou_buf_prepare, .buf_prepare = sh_vou_buf_prepare,
.buf_queue = sh_vou_buf_queue, .buf_queue = sh_vou_buf_queue,
......
...@@ -536,7 +536,7 @@ static void stop_streaming(struct vb2_queue *vq) ...@@ -536,7 +536,7 @@ static void stop_streaming(struct vb2_queue *vq)
pm_runtime_put(ici->v4l2_dev.dev); pm_runtime_put(ici->v4l2_dev.dev);
} }
static struct vb2_ops isi_video_qops = { static const struct vb2_ops isi_video_qops = {
.queue_setup = queue_setup, .queue_setup = queue_setup,
.buf_init = buffer_init, .buf_init = buffer_init,
.buf_prepare = buffer_prepare, .buf_prepare = buffer_prepare,
......
...@@ -464,7 +464,7 @@ static void sh_mobile_ceu_stop_streaming(struct vb2_queue *q) ...@@ -464,7 +464,7 @@ static void sh_mobile_ceu_stop_streaming(struct vb2_queue *q)
sh_mobile_ceu_soft_reset(pcdev); sh_mobile_ceu_soft_reset(pcdev);
} }
static struct vb2_ops sh_mobile_ceu_videobuf_ops = { static const struct vb2_ops sh_mobile_ceu_videobuf_ops = {
.queue_setup = sh_mobile_ceu_videobuf_setup, .queue_setup = sh_mobile_ceu_videobuf_setup,
.buf_prepare = sh_mobile_ceu_videobuf_prepare, .buf_prepare = sh_mobile_ceu_videobuf_prepare,
.buf_queue = sh_mobile_ceu_videobuf_queue, .buf_queue = sh_mobile_ceu_videobuf_queue,
......
...@@ -527,7 +527,7 @@ static void bdisp_stop_streaming(struct vb2_queue *q) ...@@ -527,7 +527,7 @@ static void bdisp_stop_streaming(struct vb2_queue *q)
pm_runtime_put(ctx->bdisp_dev->dev); pm_runtime_put(ctx->bdisp_dev->dev);
} }
static struct vb2_ops bdisp_qops = { static const struct vb2_ops bdisp_qops = {
.queue_setup = bdisp_queue_setup, .queue_setup = bdisp_queue_setup,
.buf_prepare = bdisp_buf_prepare, .buf_prepare = bdisp_buf_prepare,
.buf_queue = bdisp_buf_queue, .buf_queue = bdisp_buf_queue,
......
...@@ -1379,7 +1379,7 @@ static void cal_stop_streaming(struct vb2_queue *vq) ...@@ -1379,7 +1379,7 @@ static void cal_stop_streaming(struct vb2_queue *vq)
cal_runtime_put(ctx->dev); cal_runtime_put(ctx->dev);
} }
static struct vb2_ops cal_video_qops = { static const struct vb2_ops cal_video_qops = {
.queue_setup = cal_queue_setup, .queue_setup = cal_queue_setup,
.buf_prepare = cal_buffer_prepare, .buf_prepare = cal_buffer_prepare,
.buf_queue = cal_buffer_queue, .buf_queue = cal_buffer_queue,
......
...@@ -1878,7 +1878,7 @@ static void vpe_stop_streaming(struct vb2_queue *q) ...@@ -1878,7 +1878,7 @@ static void vpe_stop_streaming(struct vb2_queue *q)
vpdma_dump_regs(ctx->dev->vpdma); vpdma_dump_regs(ctx->dev->vpdma);
} }
static struct vb2_ops vpe_qops = { static const struct vb2_ops vpe_qops = {
.queue_setup = vpe_queue_setup, .queue_setup = vpe_queue_setup,
.buf_prepare = vpe_buf_prepare, .buf_prepare = vpe_buf_prepare,
.buf_queue = vpe_buf_queue, .buf_queue = vpe_buf_queue,
......
...@@ -815,7 +815,7 @@ static void vim2m_stop_streaming(struct vb2_queue *q) ...@@ -815,7 +815,7 @@ static void vim2m_stop_streaming(struct vb2_queue *q)
} }
} }
static struct vb2_ops vim2m_qops = { static const struct vb2_ops vim2m_qops = {
.queue_setup = vim2m_queue_setup, .queue_setup = vim2m_queue_setup,
.buf_prepare = vim2m_buf_prepare, .buf_prepare = vim2m_buf_prepare,
.buf_queue = vim2m_buf_queue, .buf_queue = vim2m_buf_queue,
......
...@@ -474,7 +474,7 @@ static void xvip_dma_stop_streaming(struct vb2_queue *vq) ...@@ -474,7 +474,7 @@ static void xvip_dma_stop_streaming(struct vb2_queue *vq)
spin_unlock_irq(&dma->queued_lock); spin_unlock_irq(&dma->queued_lock);
} }
static struct vb2_ops xvip_dma_queue_qops = { static const struct vb2_ops xvip_dma_queue_qops = {
.queue_setup = xvip_dma_queue_setup, .queue_setup = xvip_dma_queue_setup,
.buf_prepare = xvip_dma_buffer_prepare, .buf_prepare = xvip_dma_buffer_prepare,
.buf_queue = xvip_dma_buffer_queue, .buf_queue = xvip_dma_buffer_queue,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment