Commit b8943902 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Jonathan Cameron

iio: adc: ep93xx: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new() which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: default avatarAlexander Sverdlin <alexander.sverdlin@gmail.com>
Link: https://lore.kernel.org/r/20230919174931.1417681-9-u.kleine-koenig@pengutronix.deSigned-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
parent cb299d2a
...@@ -217,15 +217,13 @@ static int ep93xx_adc_probe(struct platform_device *pdev) ...@@ -217,15 +217,13 @@ static int ep93xx_adc_probe(struct platform_device *pdev)
return ret; return ret;
} }
static int ep93xx_adc_remove(struct platform_device *pdev) static void ep93xx_adc_remove(struct platform_device *pdev)
{ {
struct iio_dev *iiodev = platform_get_drvdata(pdev); struct iio_dev *iiodev = platform_get_drvdata(pdev);
struct ep93xx_adc_priv *priv = iio_priv(iiodev); struct ep93xx_adc_priv *priv = iio_priv(iiodev);
iio_device_unregister(iiodev); iio_device_unregister(iiodev);
clk_disable_unprepare(priv->clk); clk_disable_unprepare(priv->clk);
return 0;
} }
static const struct of_device_id ep93xx_adc_of_ids[] = { static const struct of_device_id ep93xx_adc_of_ids[] = {
...@@ -240,7 +238,7 @@ static struct platform_driver ep93xx_adc_driver = { ...@@ -240,7 +238,7 @@ static struct platform_driver ep93xx_adc_driver = {
.of_match_table = ep93xx_adc_of_ids, .of_match_table = ep93xx_adc_of_ids,
}, },
.probe = ep93xx_adc_probe, .probe = ep93xx_adc_probe,
.remove = ep93xx_adc_remove, .remove_new = ep93xx_adc_remove,
}; };
module_platform_driver(ep93xx_adc_driver); module_platform_driver(ep93xx_adc_driver);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment