Commit b8b2de91 authored by Wei Yongjun's avatar Wei Yongjun Committed by David S. Miller

net: lantiq: Fix return value check in xrx200_probe()

In case of error, the function devm_ioremap_resource() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check should
be replaced with IS_ERR().

Fixes: fe1a5642 ("net: lantiq: Add Lantiq / Intel VRX200 Ethernet driver")
Signed-off-by: default avatarWei Yongjun <weiyongjun1@huawei.com>
Acked-by: default avatarHauke Mehrtens <hauke@hauke-m.de>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent f592e0b9
...@@ -461,9 +461,9 @@ static int xrx200_probe(struct platform_device *pdev) ...@@ -461,9 +461,9 @@ static int xrx200_probe(struct platform_device *pdev)
} }
priv->pmac_reg = devm_ioremap_resource(dev, res); priv->pmac_reg = devm_ioremap_resource(dev, res);
if (!priv->pmac_reg) { if (IS_ERR(priv->pmac_reg)) {
dev_err(dev, "failed to request and remap io ranges\n"); dev_err(dev, "failed to request and remap io ranges\n");
return -ENOMEM; return PTR_ERR(priv->pmac_reg);
} }
priv->chan_rx.dma.irq = platform_get_irq_byname(pdev, "rx"); priv->chan_rx.dma.irq = platform_get_irq_byname(pdev, "rx");
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment