Commit b9b09422 authored by Pete Zaitcev's avatar Pete Zaitcev Committed by Greg Kroah-Hartman

[PATCH] USB: Let usbmon collect less garbage

Alan Stern pointed out that (in 2.6 kernel) one successful submission results
in one callback, even for ISO-out transfers. Thus, the silly check can be
removed from usbmon. This reduces the amount of garbage printed in case
of ISO and Interrupt transfers.
Signed-off-by: default avatarPete Zaitcev <zaitcev@redhat.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 687f5f34
...@@ -97,12 +97,6 @@ static inline char mon_text_get_data(struct mon_event_text *ep, struct urb *urb, ...@@ -97,12 +97,6 @@ static inline char mon_text_get_data(struct mon_event_text *ep, struct urb *urb,
if (len >= DATA_MAX) if (len >= DATA_MAX)
len = DATA_MAX; len = DATA_MAX;
/*
* Bulk is easy to shortcut reliably.
* XXX Other pipe types need consideration. Currently, we overdo it
* and collect garbage for them: better more than less.
*/
if (usb_pipebulk(pipe) || usb_pipecontrol(pipe)) {
if (usb_pipein(pipe)) { if (usb_pipein(pipe)) {
if (ev_type == 'S') if (ev_type == 'S')
return '<'; return '<';
...@@ -110,7 +104,6 @@ static inline char mon_text_get_data(struct mon_event_text *ep, struct urb *urb, ...@@ -110,7 +104,6 @@ static inline char mon_text_get_data(struct mon_event_text *ep, struct urb *urb,
if (ev_type == 'C') if (ev_type == 'C')
return '>'; return '>';
} }
}
/* /*
* The check to see if it's safe to poke at data has an enormous * The check to see if it's safe to poke at data has an enormous
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment