Commit badc7414 authored by Miklos Szeredi's avatar Miklos Szeredi

fuse: move option checking into fuse_fill_super()

Checking whether the "fd=", "rootmode=", "user_id=" and "group_id=" mount
options are present can be moved from fuse_get_tree() into
fuse_fill_super() where the value of the options are consumed.

This relaxes semantics of reusing a fuse blockdev mount using the device
name.  Before this patch presence of these options were enforced but values
ignored, after this patch these options are completely ignored in this
case.
Signed-off-by: default avatarMiklos Szeredi <mszeredi@redhat.com>
parent 84c21507
...@@ -1514,6 +1514,10 @@ static int fuse_fill_super(struct super_block *sb, struct fs_context *fsc) ...@@ -1514,6 +1514,10 @@ static int fuse_fill_super(struct super_block *sb, struct fs_context *fsc)
struct fuse_conn *fc; struct fuse_conn *fc;
struct fuse_mount *fm; struct fuse_mount *fm;
if (!ctx->fd_present || !ctx->rootmode_present ||
!ctx->user_id_present || !ctx->group_id_present)
return -EINVAL;
err = -EINVAL; err = -EINVAL;
file = fget(ctx->fd); file = fget(ctx->fd);
if (!file) if (!file)
...@@ -1570,14 +1574,9 @@ static int fuse_get_tree(struct fs_context *fsc) ...@@ -1570,14 +1574,9 @@ static int fuse_get_tree(struct fs_context *fsc)
{ {
struct fuse_fs_context *ctx = fsc->fs_private; struct fuse_fs_context *ctx = fsc->fs_private;
if (!ctx->fd_present || !ctx->rootmode_present || if (IS_ENABLED(CONFIG_BLOCK) && ctx->is_bdev) {
!ctx->user_id_present || !ctx->group_id_present)
return -EINVAL;
#ifdef CONFIG_BLOCK
if (ctx->is_bdev)
return get_tree_bdev(fsc, fuse_fill_super); return get_tree_bdev(fsc, fuse_fill_super);
#endif }
return get_tree_nodev(fsc, fuse_fill_super); return get_tree_nodev(fsc, fuse_fill_super);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment