Commit bb644ded authored by Changbin Du's avatar Changbin Du Committed by Greg Kroah-Hartman

perf top: Fix error handling in cmd_top()

[ Upstream commit 70c819e4 ]

We should go to the cleanup path, to avoid leaks, detected using gcc's
ASan.
Signed-off-by: default avatarChangbin Du <changbin.du@gmail.com>
Reviewed-by: default avatarJiri Olsa <jolsa@kernel.org>
Cc: Alexei Starovoitov <ast@kernel.org>
Cc: Daniel Borkmann <daniel@iogearbox.net>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Steven Rostedt (VMware) <rostedt@goodmis.org>
Link: http://lkml.kernel.org/r/20190316080556.3075-9-changbin.du@gmail.comSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent df894a04
...@@ -1491,8 +1491,9 @@ int cmd_top(int argc, const char **argv) ...@@ -1491,8 +1491,9 @@ int cmd_top(int argc, const char **argv)
annotation_config__init(); annotation_config__init();
symbol_conf.try_vmlinux_path = (symbol_conf.vmlinux_name == NULL); symbol_conf.try_vmlinux_path = (symbol_conf.vmlinux_name == NULL);
if (symbol__init(NULL) < 0) status = symbol__init(NULL);
return -1; if (status < 0)
goto out_delete_evlist;
sort__setup_elide(stdout); sort__setup_elide(stdout);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment