Commit bb76cc45 authored by Matti Vaittinen's avatar Matti Vaittinen Committed by Jonathan Cameron

iio: gts-helper: Fix division loop

The loop based 64bit division may run for a long time when dividend is a
lot bigger than the divider. Replace the division loop by the
div64_u64() which implementation may be significantly faster.
Tested-by: default avatarSubhajit Ghosh <subhajit.ghosh@tweaklogic.com>
Signed-off-by: default avatarMatti Vaittinen <mazziesaccount@gmail.com>
Fixes: 38416c28 ("iio: light: Add gain-time-scale helpers")
Link: https://lore.kernel.org/r/Zcn-6e-0-nh2WcfU@drtxq0yyyyyyyyyyyyyby-3.rev.dnainternet.fiSigned-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
parent 3ad0e7e5
...@@ -34,24 +34,11 @@ ...@@ -34,24 +34,11 @@
static int iio_gts_get_gain(const u64 max, const u64 scale) static int iio_gts_get_gain(const u64 max, const u64 scale)
{ {
u64 full = max; u64 full = max;
int tmp = 1;
if (scale > full || !scale) if (scale > full || !scale)
return -EINVAL; return -EINVAL;
if (U64_MAX - full < scale) { return div64_u64(full, scale);
/* Risk of overflow */
if (full - scale < scale)
return 1;
full -= scale;
tmp++;
}
while (full > scale * (u64)tmp)
tmp++;
return tmp;
} }
/** /**
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment