Commit bb8adb2e authored by Jens Axboe's avatar Jens Axboe Committed by James Bottomley

[PATCH] 3ware bad queuecommand returns

If your ->queuecommand() completes a command through done, it must not
return non-zero to the mid layer so that it takes ownership of the
command again.
Signed-off-by: default avatarJens Axboe <axboe@suse.de>

corrected typo
Signed-off-by: default avatarJames Bottomley <James.Bottomley@SteelEye.com>
parent 621df624
...@@ -1746,6 +1746,7 @@ static int twa_scsi_queue(struct scsi_cmnd *SCpnt, void (*done)(struct scsi_cmnd ...@@ -1746,6 +1746,7 @@ static int twa_scsi_queue(struct scsi_cmnd *SCpnt, void (*done)(struct scsi_cmnd
twa_free_request_id(tw_dev, request_id); twa_free_request_id(tw_dev, request_id);
SCpnt->result = (DID_ERROR << 16); SCpnt->result = (DID_ERROR << 16);
done(SCpnt); done(SCpnt);
retval = 0;
} }
return retval; return retval;
......
...@@ -2067,6 +2067,7 @@ static int tw_scsi_queue(struct scsi_cmnd *SCpnt, void (*done)(struct scsi_cmnd ...@@ -2067,6 +2067,7 @@ static int tw_scsi_queue(struct scsi_cmnd *SCpnt, void (*done)(struct scsi_cmnd
tw_state_request_finish(tw_dev, request_id); tw_state_request_finish(tw_dev, request_id);
SCpnt->result = (DID_ERROR << 16); SCpnt->result = (DID_ERROR << 16);
done(SCpnt); done(SCpnt);
retval = 0;
} }
out: out:
return retval; return retval;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment