Commit bc64ce98 authored by Jérémy Lefaure's avatar Jérémy Lefaure Committed by Mauro Carvalho Chehab

media: staging: atomisp: use ARRAY_SIZE

Using the ARRAY_SIZE macro improves the readability of the code. Also,
it is useless to use a variable to store this constant calculated at
compile time.

Found with Coccinelle with the following semantic patch:
@r depends on (org || report)@
type T;
T[] E;
position p;
@@
(
 (sizeof(E)@p /sizeof(*E))
|
 (sizeof(E)@p /sizeof(E[...]))
|
 (sizeof(E)@p /sizeof(T))
)
Signed-off-by: default avatarJérémy Lefaure <jeremy.lefaure@lse.epita.fr>
Signed-off-by: default avatarSakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
parent 79bd3daa
...@@ -22,6 +22,7 @@ ...@@ -22,6 +22,7 @@
#include <assert_support.h> #include <assert_support.h>
/* HRT_GDC_N */ /* HRT_GDC_N */
#include "gdc_device.h" #include "gdc_device.h"
#include <linux/kernel.h>
/* This module provides a binary descriptions to used to find a binary. Since, /* This module provides a binary descriptions to used to find a binary. Since,
* every stage is associated with a binary, it implicity helps stage * every stage is associated with a binary, it implicity helps stage
...@@ -147,11 +148,9 @@ enum ia_css_err sh_css_bds_factor_get_numerator_denominator( ...@@ -147,11 +148,9 @@ enum ia_css_err sh_css_bds_factor_get_numerator_denominator(
unsigned int *bds_factor_denominator) unsigned int *bds_factor_denominator)
{ {
unsigned int i; unsigned int i;
unsigned int bds_list_size = sizeof(bds_factors_list) /
sizeof(struct sh_css_bds_factor);
/* Loop over all bds factors until a match is found */ /* Loop over all bds factors until a match is found */
for (i = 0; i < bds_list_size; i++) { for (i = 0; i < ARRAY_SIZE(bds_factors_list); i++) {
if (bds_factors_list[i].bds_factor == bds_factor) { if (bds_factors_list[i].bds_factor == bds_factor) {
*bds_factor_numerator = bds_factors_list[i].numerator; *bds_factor_numerator = bds_factors_list[i].numerator;
*bds_factor_denominator = bds_factors_list[i].denominator; *bds_factor_denominator = bds_factors_list[i].denominator;
...@@ -170,8 +169,6 @@ enum ia_css_err binarydesc_calculate_bds_factor( ...@@ -170,8 +169,6 @@ enum ia_css_err binarydesc_calculate_bds_factor(
unsigned int *bds_factor) unsigned int *bds_factor)
{ {
unsigned int i; unsigned int i;
unsigned int bds_list_size = sizeof(bds_factors_list) /
sizeof(struct sh_css_bds_factor);
unsigned int in_w = input_res.width, unsigned int in_w = input_res.width,
in_h = input_res.height, in_h = input_res.height,
out_w = output_res.width, out_h = output_res.height; out_w = output_res.width, out_h = output_res.height;
...@@ -186,7 +183,7 @@ enum ia_css_err binarydesc_calculate_bds_factor( ...@@ -186,7 +183,7 @@ enum ia_css_err binarydesc_calculate_bds_factor(
assert(out_w != 0 && out_h != 0); assert(out_w != 0 && out_h != 0);
/* Loop over all bds factors until a match is found */ /* Loop over all bds factors until a match is found */
for (i = 0; i < bds_list_size; i++) { for (i = 0; i < ARRAY_SIZE(bds_factors_list); i++) {
unsigned num = bds_factors_list[i].numerator; unsigned num = bds_factors_list[i].numerator;
unsigned den = bds_factors_list[i].denominator; unsigned den = bds_factors_list[i].denominator;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment