Commit bc8e2d62 authored by Colin Ian King's avatar Colin Ian King Committed by Mauro Carvalho Chehab

media: venus: fix loop wrap in cleanup of clks

The current pre-decrement is incorrect and should be replaced
with a post-decrement. Consider the case where the very first
clk_prepare_enable fails when i is 0; in this case the error
clean up will decrement the unsigned int which wraps to the
largest unsigned int value causing an array out of bounds read
on core->clks[i].

Detected by CoverityScan, CID#1446590 ("Out-of-bounds read")
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarHans Verkuil <hansverk@cisco.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
parent 13c2bede
...@@ -137,7 +137,7 @@ static int venus_clks_enable(struct venus_core *core) ...@@ -137,7 +137,7 @@ static int venus_clks_enable(struct venus_core *core)
return 0; return 0;
err: err:
while (--i) while (i--)
clk_disable_unprepare(core->clks[i]); clk_disable_unprepare(core->clks[i]);
return ret; return ret;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment