Commit bd1fbef7 authored by Daniel Vetter's avatar Daniel Vetter

drm/atomic: Make the kerneldoc a bit clearer

Crank up the warning a notch and point at the right set of locking
functions for atomic drivers.
Acked-by: default avatarMaxime Ripard <mripard@kernel.org>
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@intel.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Maxime Ripard <mripard@kernel.org>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20201002075620.4157591-1-daniel.vetter@ffwll.ch
parent 0c503659
...@@ -1613,11 +1613,11 @@ static void __drm_state_dump(struct drm_device *dev, struct drm_printer *p, ...@@ -1613,11 +1613,11 @@ static void __drm_state_dump(struct drm_device *dev, struct drm_printer *p,
* to dmesg in case of error irq's. (Hint, you probably want to * to dmesg in case of error irq's. (Hint, you probably want to
* ratelimit this!) * ratelimit this!)
* *
* The caller must drm_modeset_lock_all(), or if this is called * The caller must wrap this drm_modeset_lock_all_ctx() and
* from error irq handler, it should not be enabled by default. * drm_modeset_drop_locks(). If this is called from error irq handler, it should
* (Ie. if you are debugging errors you might not care that this * not be enabled by default - if you are debugging errors you might
* is racey. But calling this without all modeset locks held is * not care that this is racey, but calling this without all modeset locks held
* not inherently safe.) * is inherently unsafe.
*/ */
void drm_state_dump(struct drm_device *dev, struct drm_printer *p) void drm_state_dump(struct drm_device *dev, struct drm_printer *p)
{ {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment