Commit bdb595b4 authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman

tty: hvc_xen: NULL dereference on allocation failure

If kzalloc() returns a NULL here, we pass a NULL to
xencons_disconnect_backend() which will cause an Oops.

Also I removed the __GFP_ZERO while I was at it since kzalloc() implies
__GFP_ZERO.
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Acked-by: default avatarStefano Stabellini <stefano.stabellini@eu.citrix.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 05f843b5
...@@ -430,9 +430,9 @@ static int __devinit xencons_probe(struct xenbus_device *dev, ...@@ -430,9 +430,9 @@ static int __devinit xencons_probe(struct xenbus_device *dev,
if (devid == 0) if (devid == 0)
return -ENODEV; return -ENODEV;
info = kzalloc(sizeof(struct xencons_info), GFP_KERNEL | __GFP_ZERO); info = kzalloc(sizeof(struct xencons_info), GFP_KERNEL);
if (!info) if (!info)
goto error_nomem; return -ENOMEM;
dev_set_drvdata(&dev->dev, info); dev_set_drvdata(&dev->dev, info);
info->xbdev = dev; info->xbdev = dev;
info->vtermno = xenbus_devid_to_vtermno(devid); info->vtermno = xenbus_devid_to_vtermno(devid);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment