Commit bdfd720f authored by Paul Cercueil's avatar Paul Cercueil Committed by Sam Ravnborg

drm/panel: novatek,nt39016: Add missing CR to error messages

If you pass a string that is not terminated with a carriage return to
dev_err(), it will eventually be printed with a carriage return, but
not right away, since the kernel will wait for a pr_cont().
Signed-off-by: default avatarPaul Cercueil <paul@crapouillou.net>
Signed-off-by: default avatarSam Ravnborg <sam@ravnborg.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20200811002240.55194-3-paul@crapouillou.net
parent 5b44f125
...@@ -124,7 +124,7 @@ static int nt39016_prepare(struct drm_panel *drm_panel) ...@@ -124,7 +124,7 @@ static int nt39016_prepare(struct drm_panel *drm_panel)
err = regulator_enable(panel->supply); err = regulator_enable(panel->supply);
if (err) { if (err) {
dev_err(panel->dev, "Failed to enable power supply: %d", err); dev_err(panel->dev, "Failed to enable power supply: %d\n", err);
return err; return err;
} }
...@@ -143,7 +143,7 @@ static int nt39016_prepare(struct drm_panel *drm_panel) ...@@ -143,7 +143,7 @@ static int nt39016_prepare(struct drm_panel *drm_panel)
err = regmap_multi_reg_write(panel->map, nt39016_panel_regs, err = regmap_multi_reg_write(panel->map, nt39016_panel_regs,
ARRAY_SIZE(nt39016_panel_regs)); ARRAY_SIZE(nt39016_panel_regs));
if (err) { if (err) {
dev_err(panel->dev, "Failed to init registers: %d", err); dev_err(panel->dev, "Failed to init registers: %d\n", err);
goto err_disable_regulator; goto err_disable_regulator;
} }
...@@ -173,7 +173,7 @@ static int nt39016_enable(struct drm_panel *drm_panel) ...@@ -173,7 +173,7 @@ static int nt39016_enable(struct drm_panel *drm_panel)
ret = regmap_write(panel->map, NT39016_REG_SYSTEM, ret = regmap_write(panel->map, NT39016_REG_SYSTEM,
NT39016_SYSTEM_RESET_N | NT39016_SYSTEM_STANDBY); NT39016_SYSTEM_RESET_N | NT39016_SYSTEM_STANDBY);
if (ret) { if (ret) {
dev_err(panel->dev, "Unable to enable panel: %d", ret); dev_err(panel->dev, "Unable to enable panel: %d\n", ret);
return ret; return ret;
} }
...@@ -193,7 +193,7 @@ static int nt39016_disable(struct drm_panel *drm_panel) ...@@ -193,7 +193,7 @@ static int nt39016_disable(struct drm_panel *drm_panel)
err = regmap_write(panel->map, NT39016_REG_SYSTEM, err = regmap_write(panel->map, NT39016_REG_SYSTEM,
NT39016_SYSTEM_RESET_N); NT39016_SYSTEM_RESET_N);
if (err) { if (err) {
dev_err(panel->dev, "Unable to disable panel: %d", err); dev_err(panel->dev, "Unable to disable panel: %d\n", err);
return err; return err;
} }
...@@ -261,13 +261,13 @@ static int nt39016_probe(struct spi_device *spi) ...@@ -261,13 +261,13 @@ static int nt39016_probe(struct spi_device *spi)
panel->supply = devm_regulator_get(dev, "power"); panel->supply = devm_regulator_get(dev, "power");
if (IS_ERR(panel->supply)) { if (IS_ERR(panel->supply)) {
dev_err(dev, "Failed to get power supply"); dev_err(dev, "Failed to get power supply\n");
return PTR_ERR(panel->supply); return PTR_ERR(panel->supply);
} }
panel->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_HIGH); panel->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_HIGH);
if (IS_ERR(panel->reset_gpio)) { if (IS_ERR(panel->reset_gpio)) {
dev_err(dev, "Failed to get reset GPIO"); dev_err(dev, "Failed to get reset GPIO\n");
return PTR_ERR(panel->reset_gpio); return PTR_ERR(panel->reset_gpio);
} }
...@@ -275,20 +275,20 @@ static int nt39016_probe(struct spi_device *spi) ...@@ -275,20 +275,20 @@ static int nt39016_probe(struct spi_device *spi)
spi->mode = SPI_MODE_3 | SPI_3WIRE; spi->mode = SPI_MODE_3 | SPI_3WIRE;
err = spi_setup(spi); err = spi_setup(spi);
if (err) { if (err) {
dev_err(dev, "Failed to setup SPI"); dev_err(dev, "Failed to setup SPI\n");
return err; return err;
} }
panel->map = devm_regmap_init_spi(spi, &nt39016_regmap_config); panel->map = devm_regmap_init_spi(spi, &nt39016_regmap_config);
if (IS_ERR(panel->map)) { if (IS_ERR(panel->map)) {
dev_err(dev, "Failed to init regmap"); dev_err(dev, "Failed to init regmap\n");
return PTR_ERR(panel->map); return PTR_ERR(panel->map);
} }
err = drm_panel_of_backlight(&panel->drm_panel); err = drm_panel_of_backlight(&panel->drm_panel);
if (err) { if (err) {
if (err != -EPROBE_DEFER) if (err != -EPROBE_DEFER)
dev_err(dev, "Failed to get backlight handle"); dev_err(dev, "Failed to get backlight handle\n");
return err; return err;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment