Commit be238fbf authored by Miquel Raynal's avatar Miquel Raynal

mtd: rawnand: orion: Fix the probe error path

nand_release() is supposed be called after MTD device registration.
Here, only nand_scan() happened, so use nand_cleanup() instead.

There is no real Fixes tag applying here as the use of nand_release()
in this driver predates by far the introduction of nand_cleanup() in
commit d44154f9 ("mtd: nand: Provide nand_cleanup() function to free NAND related resources")
which makes this change possible. However, pointing this commit as the
culprit for backporting purposes makes sense even if this commit is not
introducing any bug.

Fixes: d44154f9 ("mtd: nand: Provide nand_cleanup() function to free NAND related resources")
Signed-off-by: default avatarMiquel Raynal <miquel.raynal@bootlin.com>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/linux-mtd/20200519130035.1883-34-miquel.raynal@bootlin.com
parent b4533679
...@@ -180,7 +180,7 @@ static int __init orion_nand_probe(struct platform_device *pdev) ...@@ -180,7 +180,7 @@ static int __init orion_nand_probe(struct platform_device *pdev)
mtd->name = "orion_nand"; mtd->name = "orion_nand";
ret = mtd_device_register(mtd, board->parts, board->nr_parts); ret = mtd_device_register(mtd, board->parts, board->nr_parts);
if (ret) { if (ret) {
nand_release(nc); nand_cleanup(nc);
goto no_dev; goto no_dev;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment