Commit be2af740 authored by Yang Yingliang's avatar Yang Yingliang Committed by Mark Brown

ASoC: wm2000: fix missing clk_disable_unprepare() on error in wm2000_anc_transition()

Fix the missing clk_disable_unprepare() before return
from wm2000_anc_transition() in the error handling case.

Fixes: 514cfd6d ("ASoC: wm2000: Integrate with clock API")
Signed-off-by: default avatarYang Yingliang <yangyingliang@huawei.com>
Acked-by: default avatarCharles Keepax <ckeepax@opensource.cirrus.com>
Link: https://lore.kernel.org/r/20220514091053.686416-1-yangyingliang@huawei.comSigned-off-by: default avatarMark Brown <broonie@kernel.org>
parent 81e7b165
...@@ -536,7 +536,7 @@ static int wm2000_anc_transition(struct wm2000_priv *wm2000, ...@@ -536,7 +536,7 @@ static int wm2000_anc_transition(struct wm2000_priv *wm2000,
{ {
struct i2c_client *i2c = wm2000->i2c; struct i2c_client *i2c = wm2000->i2c;
int i, j; int i, j;
int ret; int ret = 0;
if (wm2000->anc_mode == mode) if (wm2000->anc_mode == mode)
return 0; return 0;
...@@ -566,13 +566,13 @@ static int wm2000_anc_transition(struct wm2000_priv *wm2000, ...@@ -566,13 +566,13 @@ static int wm2000_anc_transition(struct wm2000_priv *wm2000,
ret = anc_transitions[i].step[j](i2c, ret = anc_transitions[i].step[j](i2c,
anc_transitions[i].analogue); anc_transitions[i].analogue);
if (ret != 0) if (ret != 0)
return ret; break;
} }
if (anc_transitions[i].dest == ANC_OFF) if (anc_transitions[i].dest == ANC_OFF)
clk_disable_unprepare(wm2000->mclk); clk_disable_unprepare(wm2000->mclk);
return 0; return ret;
} }
static int wm2000_anc_set_mode(struct wm2000_priv *wm2000) static int wm2000_anc_set_mode(struct wm2000_priv *wm2000)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment