Commit bedb361b authored by Amitkumar Karwar's avatar Amitkumar Karwar Committed by John W. Linville

mwifiex: correction in mwifiex_check_fw_status() return status

For PCIe cards, when wrong firmware is downloaded, firmware is
failed to be ready in 10 seconds. We should return an error at
this point. But currently we are sending first command to firmware.
As expected firmware doesn't respond to this command and command
timeout occurs.

This patch fixes the problem by removing unnecessary 'ret'
variable modifications in "if (ret) {" block.
The block is just supposed to update "adapter->winner" flag.
Signed-off-by: default avatarAmitkumar Karwar <akarwar@marvell.com>
Signed-off-by: default avatarBing Zhao <bzhao@marvell.com>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent a76b20e5
...@@ -1954,12 +1954,10 @@ mwifiex_check_fw_status(struct mwifiex_adapter *adapter, u32 poll_num) ...@@ -1954,12 +1954,10 @@ mwifiex_check_fw_status(struct mwifiex_adapter *adapter, u32 poll_num)
else if (!winner_status) { else if (!winner_status) {
dev_err(adapter->dev, "PCI-E is the winner\n"); dev_err(adapter->dev, "PCI-E is the winner\n");
adapter->winner = 1; adapter->winner = 1;
ret = -1;
} else { } else {
dev_err(adapter->dev, dev_err(adapter->dev,
"PCI-E is not the winner <%#x,%d>, exit dnld\n", "PCI-E is not the winner <%#x,%d>, exit dnld\n",
ret, adapter->winner); ret, adapter->winner);
ret = 0;
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment