Commit bf064c7b authored by Dwaipayan Ray's avatar Dwaipayan Ray Committed by Corey Minyard

char: ipmi: use DEVICE_ATTR helper macro

Instead of open coding DEVICE_ATTR, use the helper macro
DEVICE_ATTR_RO to replace DEVICE_ATTR with 0444 octal
permissions.

This was detected as a part of checkpatch evaluation
investigating all reports of DEVICE_ATTR_RO warning
type.
Signed-off-by: default avatarDwaipayan Ray <dwaipayanray1@gmail.com>
Message-Id: <20210730062951.84876-1-dwaipayanray1@gmail.com>
Signed-off-by: default avatarCorey Minyard <cminyard@mvista.com>
parent ca8c1c53
...@@ -1605,7 +1605,7 @@ static ssize_t name##_show(struct device *dev, \ ...@@ -1605,7 +1605,7 @@ static ssize_t name##_show(struct device *dev, \
\ \
return snprintf(buf, 10, "%u\n", smi_get_stat(smi_info, name)); \ return snprintf(buf, 10, "%u\n", smi_get_stat(smi_info, name)); \
} \ } \
static DEVICE_ATTR(name, 0444, name##_show, NULL) static DEVICE_ATTR_RO(name)
static ssize_t type_show(struct device *dev, static ssize_t type_show(struct device *dev,
struct device_attribute *attr, struct device_attribute *attr,
...@@ -1615,7 +1615,7 @@ static ssize_t type_show(struct device *dev, ...@@ -1615,7 +1615,7 @@ static ssize_t type_show(struct device *dev,
return snprintf(buf, 10, "%s\n", si_to_str[smi_info->io.si_type]); return snprintf(buf, 10, "%s\n", si_to_str[smi_info->io.si_type]);
} }
static DEVICE_ATTR(type, 0444, type_show, NULL); static DEVICE_ATTR_RO(type);
static ssize_t interrupts_enabled_show(struct device *dev, static ssize_t interrupts_enabled_show(struct device *dev,
struct device_attribute *attr, struct device_attribute *attr,
...@@ -1626,8 +1626,7 @@ static ssize_t interrupts_enabled_show(struct device *dev, ...@@ -1626,8 +1626,7 @@ static ssize_t interrupts_enabled_show(struct device *dev,
return snprintf(buf, 10, "%d\n", enabled); return snprintf(buf, 10, "%d\n", enabled);
} }
static DEVICE_ATTR(interrupts_enabled, 0444, static DEVICE_ATTR_RO(interrupts_enabled);
interrupts_enabled_show, NULL);
IPMI_SI_ATTR(short_timeouts); IPMI_SI_ATTR(short_timeouts);
IPMI_SI_ATTR(long_timeouts); IPMI_SI_ATTR(long_timeouts);
...@@ -1658,7 +1657,7 @@ static ssize_t params_show(struct device *dev, ...@@ -1658,7 +1657,7 @@ static ssize_t params_show(struct device *dev,
smi_info->io.irq, smi_info->io.irq,
smi_info->io.slave_addr); smi_info->io.slave_addr);
} }
static DEVICE_ATTR(params, 0444, params_show, NULL); static DEVICE_ATTR_RO(params);
static struct attribute *ipmi_si_dev_attrs[] = { static struct attribute *ipmi_si_dev_attrs[] = {
&dev_attr_type.attr, &dev_attr_type.attr,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment