Commit bf2944bd authored by Sean Hefty's avatar Sean Hefty Committed by Roland Dreier

RDMA/cma: Fix initialization of next_port

next_port should be between sysctl_local_port_range[0] and [1].
However, it is initially set to a random value with get_random_bytes().  
If the value is negative when treated as a signed integer, next_port
can end up outside the expected range because of the result of the % 
operator being negative.
Signed-off-by: default avatarSean Hefty <sean.hefty@intel.com>
Signed-off-by: default avatarRoland Dreier <rolandd@cisco.com>
parent 57f01b53
...@@ -2773,8 +2773,8 @@ static int cma_init(void) ...@@ -2773,8 +2773,8 @@ static int cma_init(void)
int ret; int ret;
get_random_bytes(&next_port, sizeof next_port); get_random_bytes(&next_port, sizeof next_port);
next_port = (next_port % (sysctl_local_port_range[1] - next_port = ((unsigned int) next_port %
sysctl_local_port_range[0])) + (sysctl_local_port_range[1] - sysctl_local_port_range[0])) +
sysctl_local_port_range[0]; sysctl_local_port_range[0];
cma_wq = create_singlethread_workqueue("rdma_cm"); cma_wq = create_singlethread_workqueue("rdma_cm");
if (!cma_wq) if (!cma_wq)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment