Commit bfa49cfc authored by Colin Ian King's avatar Colin Ian King Committed by David S. Miller

net/ethoc: fix null dereference on error exit path

priv is assigned to NULL however some of the early error exit paths to
label 'free' dereference priv, causing a null pointer dereference.

Move the label 'free' to just the free_netdev statement, and add a new
exit path 'free2' for the error cases were clk_disable_unprepare needs
calling before the final free.

Fixes issue found by CoverityScan, CID#113260
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Reviewed-by: default avatarMax Filippov <jcmvbkbc@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent fc14963f
...@@ -1195,7 +1195,7 @@ static int ethoc_probe(struct platform_device *pdev) ...@@ -1195,7 +1195,7 @@ static int ethoc_probe(struct platform_device *pdev)
priv->mdio = mdiobus_alloc(); priv->mdio = mdiobus_alloc();
if (!priv->mdio) { if (!priv->mdio) {
ret = -ENOMEM; ret = -ENOMEM;
goto free; goto free2;
} }
priv->mdio->name = "ethoc-mdio"; priv->mdio->name = "ethoc-mdio";
...@@ -1208,7 +1208,7 @@ static int ethoc_probe(struct platform_device *pdev) ...@@ -1208,7 +1208,7 @@ static int ethoc_probe(struct platform_device *pdev)
ret = mdiobus_register(priv->mdio); ret = mdiobus_register(priv->mdio);
if (ret) { if (ret) {
dev_err(&netdev->dev, "failed to register MDIO bus\n"); dev_err(&netdev->dev, "failed to register MDIO bus\n");
goto free; goto free2;
} }
ret = ethoc_mdio_probe(netdev); ret = ethoc_mdio_probe(netdev);
...@@ -1241,9 +1241,10 @@ static int ethoc_probe(struct platform_device *pdev) ...@@ -1241,9 +1241,10 @@ static int ethoc_probe(struct platform_device *pdev)
error: error:
mdiobus_unregister(priv->mdio); mdiobus_unregister(priv->mdio);
mdiobus_free(priv->mdio); mdiobus_free(priv->mdio);
free: free2:
if (priv->clk) if (priv->clk)
clk_disable_unprepare(priv->clk); clk_disable_unprepare(priv->clk);
free:
free_netdev(netdev); free_netdev(netdev);
out: out:
return ret; return ret;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment