Commit bfecbcb5 authored by Jorge Lopez's avatar Jorge Lopez Committed by Hans de Goede

platform/x86: hp-bioscfg: Remove duplicate use of variable in inner loop

Replace use of same variable in inner loop.
Signed-off-by: default avatarJorge Lopez <jorge.lopez2@hp.com>
Link: https://lore.kernel.org/r/20230731203141.30044-9-jorge.lopez2@hp.comReviewed-by: default avatarHans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
parent efd4211e
...@@ -136,6 +136,7 @@ static int hp_populate_ordered_list_elements_from_package(union acpi_object *ord ...@@ -136,6 +136,7 @@ static int hp_populate_ordered_list_elements_from_package(union acpi_object *ord
u32 size; u32 size;
u32 int_value = 0; u32 int_value = 0;
int elem; int elem;
int olist_elem;
int reqs; int reqs;
int eloc; int eloc;
char *tmpstr = NULL; char *tmpstr = NULL;
...@@ -147,10 +148,7 @@ static int hp_populate_ordered_list_elements_from_package(union acpi_object *ord ...@@ -147,10 +148,7 @@ static int hp_populate_ordered_list_elements_from_package(union acpi_object *ord
if (!order_obj) if (!order_obj)
return -EINVAL; return -EINVAL;
for (elem = 1, eloc = 1; elem < order_obj_count; elem++, eloc++) { for (elem = 1, eloc = 1; eloc < ORD_ELEM_CNT; elem++, eloc++) {
/* ONLY look at the first ORDERED_ELEM_CNT elements */
if (eloc == ORD_ELEM_CNT)
goto exit_list;
switch (order_obj[elem].type) { switch (order_obj[elem].type) {
case ACPI_TYPE_STRING: case ACPI_TYPE_STRING:
...@@ -277,10 +275,10 @@ static int hp_populate_ordered_list_elements_from_package(union acpi_object *ord ...@@ -277,10 +275,10 @@ static int hp_populate_ordered_list_elements_from_package(union acpi_object *ord
tmpstr, tmpstr,
sizeof(ordered_list_data->elements[0])); sizeof(ordered_list_data->elements[0]));
for (elem = 1; elem < MAX_ELEMENTS_SIZE && part; elem++) { for (olist_elem = 1; olist_elem < MAX_ELEMENTS_SIZE && part; olist_elem++) {
strscpy(ordered_list_data->elements[elem], strscpy(ordered_list_data->elements[olist_elem],
part, part,
sizeof(ordered_list_data->elements[elem])); sizeof(ordered_list_data->elements[olist_elem]));
part = strsep(&part_tmp, SEMICOLON_SEP); part = strsep(&part_tmp, SEMICOLON_SEP);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment