Commit c0e4a6f5 authored by Sagi Grimberg's avatar Sagi Grimberg Committed by Jens Axboe

nvme-fc: fix module_init (theoretical) error path

If nvmf_register_transport happened to fail
(it can't, but theoretically) we leak memory.
Signed-off-by: default avatarSagi Grimberg <sagi@grimberg.me>
Signed-off-by: default avatarJens Axboe <axboe@fb.com>
parent d19eef02
...@@ -2546,11 +2546,20 @@ static struct nvmf_transport_ops nvme_fc_transport = { ...@@ -2546,11 +2546,20 @@ static struct nvmf_transport_ops nvme_fc_transport = {
static int __init nvme_fc_init_module(void) static int __init nvme_fc_init_module(void)
{ {
int ret;
nvme_fc_wq = create_workqueue("nvme_fc_wq"); nvme_fc_wq = create_workqueue("nvme_fc_wq");
if (!nvme_fc_wq) if (!nvme_fc_wq)
return -ENOMEM; return -ENOMEM;
return nvmf_register_transport(&nvme_fc_transport); ret = nvmf_register_transport(&nvme_fc_transport);
if (ret)
goto err;
return 0;
err:
destroy_workqueue(nvme_fc_wq);
return ret;
} }
static void __exit nvme_fc_exit_module(void) static void __exit nvme_fc_exit_module(void)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment