Commit c0e8ed04 authored by Helge Deller's avatar Helge Deller Committed by Martin K. Petersen

scsi: sym53c8xx: Avoid undefined behaviour

On parisc I see this UBSAN warning with a sym53c896:

 UBSAN: Undefined behaviour in ./drivers/scsi/sym53c8xx_2/sym_hipd.c:762:24
 index -1903078336 is out of range for type 'u32 [7]'

Avoid this warning by switching to div64_ul().

[mkp: fix typo]
Signed-off-by: default avatarHelge Deller <deller@gmx.de>
Reviewed-by: default avatarJohannes Thumshirn <jthumshirn@suse.de>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 8a97712e
...@@ -759,7 +759,7 @@ static int sym_prepare_setting(struct Scsi_Host *shost, struct sym_hcb *np, stru ...@@ -759,7 +759,7 @@ static int sym_prepare_setting(struct Scsi_Host *shost, struct sym_hcb *np, stru
/* /*
* Maximum synchronous period factor supported by the chip. * Maximum synchronous period factor supported by the chip.
*/ */
period = (11 * div_10M[np->clock_divn - 1]) / (4 * np->clock_khz); period = div64_ul(11 * div_10M[np->clock_divn - 1], 4 * np->clock_khz);
np->maxsync = period > 2540 ? 254 : period / 10; np->maxsync = period > 2540 ? 254 : period / 10;
/* /*
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment