Commit c1e0a182 authored by Paolo Valente's avatar Paolo Valente Committed by Jens Axboe

block, bfq: reduce upper bound for inject limit to max_rq_in_driver+1

Upon an increment attempt of the injection limit, the latter is
constrained not to become higher than twice the maximum number
max_rq_in_driver of I/O requests that have happened to be in service
in the drive. This high bound allows the injection limit to grow
beyond max_rq_in_driver, which may then cause max_rq_in_driver itself
to grow.

However, since the limit is incremented by only one unit at a time,
there is no need for such a high bound, and just max_rq_in_driver+1 is
enough.
Tested-by: default avatarOleksandr Natalenko <oleksandr@natalenko.name>
Signed-off-by: default avatarPaolo Valente <paolo.valente@linaro.org>
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 23ed570a
...@@ -5805,7 +5805,7 @@ static void bfq_update_inject_limit(struct bfq_data *bfqd, ...@@ -5805,7 +5805,7 @@ static void bfq_update_inject_limit(struct bfq_data *bfqd,
bfqq->inject_limit--; bfqq->inject_limit--;
bfqq->decrease_time_jif = jiffies; bfqq->decrease_time_jif = jiffies;
} else if (tot_time_ns < threshold && } else if (tot_time_ns < threshold &&
old_limit < bfqd->max_rq_in_driver<<1) old_limit <= bfqd->max_rq_in_driver)
bfqq->inject_limit++; bfqq->inject_limit++;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment