Commit c26bdea4 authored by Ajay Singh's avatar Ajay Singh Committed by Greg Kroah-Hartman

staging: wilc1000: free memory allocated in add wep key functions

Free memory allocated for wep key when command enqueue is failed.
Signed-off-by: default avatarAjay Singh <ajay.kathat@microchip.com>
Reviewed-by: default avatarClaudiu Beznea <claudiu.beznea@microchip.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 7ab3e668
...@@ -2716,7 +2716,7 @@ int wilc_set_wep_default_keyid(struct wilc_vif *vif, u8 index) ...@@ -2716,7 +2716,7 @@ int wilc_set_wep_default_keyid(struct wilc_vif *vif, u8 index)
int wilc_add_wep_key_bss_sta(struct wilc_vif *vif, const u8 *key, u8 len, int wilc_add_wep_key_bss_sta(struct wilc_vif *vif, const u8 *key, u8 len,
u8 index) u8 index)
{ {
int result = 0; int result;
struct host_if_msg msg; struct host_if_msg msg;
struct host_if_drv *hif_drv = vif->hif_drv; struct host_if_drv *hif_drv = vif->hif_drv;
...@@ -2739,17 +2739,20 @@ int wilc_add_wep_key_bss_sta(struct wilc_vif *vif, const u8 *key, u8 len, ...@@ -2739,17 +2739,20 @@ int wilc_add_wep_key_bss_sta(struct wilc_vif *vif, const u8 *key, u8 len,
msg.body.key_info.attr.wep.index = index; msg.body.key_info.attr.wep.index = index;
result = wilc_enqueue_cmd(&msg); result = wilc_enqueue_cmd(&msg);
if (result) if (result) {
netdev_err(vif->ndev, "STA - WEP Key\n"); netdev_err(vif->ndev, "STA - WEP Key\n");
wait_for_completion(&hif_drv->comp_test_key_block); kfree(msg.body.key_info.attr.wep.key);
return result;
}
return result; wait_for_completion(&hif_drv->comp_test_key_block);
return 0;
} }
int wilc_add_wep_key_bss_ap(struct wilc_vif *vif, const u8 *key, u8 len, int wilc_add_wep_key_bss_ap(struct wilc_vif *vif, const u8 *key, u8 len,
u8 index, u8 mode, enum AUTHTYPE auth_type) u8 index, u8 mode, enum AUTHTYPE auth_type)
{ {
int result = 0; int result;
struct host_if_msg msg; struct host_if_msg msg;
struct host_if_drv *hif_drv = vif->hif_drv; struct host_if_drv *hif_drv = vif->hif_drv;
...@@ -2774,13 +2777,14 @@ int wilc_add_wep_key_bss_ap(struct wilc_vif *vif, const u8 *key, u8 len, ...@@ -2774,13 +2777,14 @@ int wilc_add_wep_key_bss_ap(struct wilc_vif *vif, const u8 *key, u8 len,
msg.body.key_info.attr.wep.auth_type = auth_type; msg.body.key_info.attr.wep.auth_type = auth_type;
result = wilc_enqueue_cmd(&msg); result = wilc_enqueue_cmd(&msg);
if (result) {
if (result)
netdev_err(vif->ndev, "AP - WEP Key\n"); netdev_err(vif->ndev, "AP - WEP Key\n");
else kfree(msg.body.key_info.attr.wep.key);
wait_for_completion(&hif_drv->comp_test_key_block); return result;
}
return result; wait_for_completion(&hif_drv->comp_test_key_block);
return 0;
} }
int wilc_add_ptk(struct wilc_vif *vif, const u8 *ptk, u8 ptk_key_len, int wilc_add_ptk(struct wilc_vif *vif, const u8 *ptk, u8 ptk_key_len,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment