Commit c29d4257 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Vinod Koul

phy: ti: phy-ti-pipe3: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230307115900.2293120-31-u.kleine-koenig@pengutronix.deSigned-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 5566da71
...@@ -841,7 +841,7 @@ static int ti_pipe3_probe(struct platform_device *pdev) ...@@ -841,7 +841,7 @@ static int ti_pipe3_probe(struct platform_device *pdev)
return PTR_ERR_OR_ZERO(phy_provider); return PTR_ERR_OR_ZERO(phy_provider);
} }
static int ti_pipe3_remove(struct platform_device *pdev) static void ti_pipe3_remove(struct platform_device *pdev)
{ {
struct ti_pipe3 *phy = platform_get_drvdata(pdev); struct ti_pipe3 *phy = platform_get_drvdata(pdev);
...@@ -850,8 +850,6 @@ static int ti_pipe3_remove(struct platform_device *pdev) ...@@ -850,8 +850,6 @@ static int ti_pipe3_remove(struct platform_device *pdev)
phy->sata_refclk_enabled = false; phy->sata_refclk_enabled = false;
} }
pm_runtime_disable(&pdev->dev); pm_runtime_disable(&pdev->dev);
return 0;
} }
static int ti_pipe3_enable_clocks(struct ti_pipe3 *phy) static int ti_pipe3_enable_clocks(struct ti_pipe3 *phy)
...@@ -928,7 +926,7 @@ MODULE_DEVICE_TABLE(of, ti_pipe3_id_table); ...@@ -928,7 +926,7 @@ MODULE_DEVICE_TABLE(of, ti_pipe3_id_table);
static struct platform_driver ti_pipe3_driver = { static struct platform_driver ti_pipe3_driver = {
.probe = ti_pipe3_probe, .probe = ti_pipe3_probe,
.remove = ti_pipe3_remove, .remove_new = ti_pipe3_remove,
.driver = { .driver = {
.name = "ti-pipe3", .name = "ti-pipe3",
.of_match_table = ti_pipe3_id_table, .of_match_table = ti_pipe3_id_table,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment