Commit c2af6b07 authored by Pawel Laszczak's avatar Pawel Laszczak Committed by Felipe Balbi

usb:gadget Simplify usb_decode_get_set_descriptor function.

Patch moves switch responsible for decoding descriptor type
outside snprintf. It improves code readability a little.
Signed-off-by: default avatarPawel Laszczak <pawell@cadence.com>
Signed-off-by: default avatarFelipe Balbi <felipe.balbi@linux.intel.com>
parent ca888ce7
...@@ -105,9 +105,8 @@ static void usb_decode_get_set_descriptor(__u8 bRequestType, __u8 bRequest, ...@@ -105,9 +105,8 @@ static void usb_decode_get_set_descriptor(__u8 bRequestType, __u8 bRequest,
__u16 wValue, __u16 wIndex, __u16 wValue, __u16 wIndex,
__u16 wLength, char *str, size_t size) __u16 wLength, char *str, size_t size)
{ {
snprintf(str, size, "%s %s Descriptor(Index = %d, Length = %d)", char *s;
bRequest == USB_REQ_GET_DESCRIPTOR ? "Get" : "Set",
({ char *s;
switch (wValue >> 8) { switch (wValue >> 8) {
case USB_DT_DEVICE: case USB_DT_DEVICE:
s = "Device"; s = "Device";
...@@ -160,7 +159,11 @@ static void usb_decode_get_set_descriptor(__u8 bRequestType, __u8 bRequest, ...@@ -160,7 +159,11 @@ static void usb_decode_get_set_descriptor(__u8 bRequestType, __u8 bRequest,
default: default:
s = "UNKNOWN"; s = "UNKNOWN";
break; break;
} s; }), wValue & 0xff, wLength); }
snprintf(str, size, "%s %s Descriptor(Index = %d, Length = %d)",
bRequest == USB_REQ_GET_DESCRIPTOR ? "Get" : "Set",
s, wValue & 0xff, wLength);
} }
static void usb_decode_get_configuration(__u16 wLength, char *str, size_t size) static void usb_decode_get_configuration(__u16 wLength, char *str, size_t size)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment