Commit c2eaf5e0 authored by Douglas Anderson's avatar Douglas Anderson Committed by Greg Kroah-Hartman

serial: qcom-geni: fix arg types for qcom_geni_serial_poll_bit()

The "offset" passed in should be unsigned since it's always a positive
offset from our memory mapped IO.

The "field" should be u32 since we're anding it with a 32-bit value
read from the device.
Suggested-by: default avatarStephen Boyd <swboyd@chromium.org>
Signed-off-by: default avatarDouglas Anderson <dianders@chromium.org>
Reviewed-by: default avatarKonrad Dybcio <konrad.dybcio@linaro.org>
Link: https://lore.kernel.org/r/20240610152420.v4.4.I24a0de52dd7336908df180fa6b698e001f3aff82@changeidTested-by: default avatarNícolas F. R. A. Prado <nfraprado@collabora.com>
Signed-off-by: default avatarJohan Hovold <johan+linaro@kernel.org>
Link: https://lore.kernel.org/r/20240906131336.23625-5-johan+linaro@kernel.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent b03ffc76
...@@ -266,7 +266,7 @@ static bool qcom_geni_serial_secondary_active(struct uart_port *uport) ...@@ -266,7 +266,7 @@ static bool qcom_geni_serial_secondary_active(struct uart_port *uport)
} }
static bool qcom_geni_serial_poll_bit(struct uart_port *uport, static bool qcom_geni_serial_poll_bit(struct uart_port *uport,
int offset, int field, bool set) unsigned int offset, u32 field, bool set)
{ {
u32 reg; u32 reg;
struct qcom_geni_serial_port *port; struct qcom_geni_serial_port *port;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment