Commit c2f14ba7 authored by Markus Elfring's avatar Markus Elfring Committed by Takashi Iwai

ALSA: compress: Use memdup_user() rather than duplicating its implementation

Reuse existing functionality from memdup_user() instead of keeping
duplicate source code.

This issue was detected by using the Coccinelle software.
Signed-off-by: default avatarMarkus Elfring <elfring@users.sourceforge.net>
Acked-by: default avatarVinod Koul <vinod.koul@intel.com>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 1bc00f32
...@@ -553,13 +553,9 @@ snd_compr_set_params(struct snd_compr_stream *stream, unsigned long arg) ...@@ -553,13 +553,9 @@ snd_compr_set_params(struct snd_compr_stream *stream, unsigned long arg)
* we should allow parameter change only when stream has been * we should allow parameter change only when stream has been
* opened not in other cases * opened not in other cases
*/ */
params = kmalloc(sizeof(*params), GFP_KERNEL); params = memdup_user((void __user *)arg, sizeof(*params));
if (!params) if (IS_ERR(params))
return -ENOMEM; return PTR_ERR(params);
if (copy_from_user(params, (void __user *)arg, sizeof(*params))) {
retval = -EFAULT;
goto out;
}
retval = snd_compress_check_input(params); retval = snd_compress_check_input(params);
if (retval) if (retval)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment