Commit c301b1d8 authored by Kan Liang's avatar Kan Liang Committed by Peter Zijlstra

perf/x86/intel/lbr: Add a function pointer for LBR read

The method to read Architectural LBRs is different from previous
model-specific LBR. Perf has to implement a different function.

A function pointer for LBR read is introduced. Perf should initialize
the corresponding function at boot time, and avoid checking lbr_format
at run time.

The current 64-bit LBR read function is set as default.
Signed-off-by: default avatarKan Liang <kan.liang@linux.intel.com>
Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lkml.kernel.org/r/1593780569-62993-4-git-send-email-kan.liang@linux.intel.com
parent 9f354a72
...@@ -3980,6 +3980,7 @@ static __initconst const struct x86_pmu core_pmu = { ...@@ -3980,6 +3980,7 @@ static __initconst const struct x86_pmu core_pmu = {
.check_period = intel_pmu_check_period, .check_period = intel_pmu_check_period,
.lbr_reset = intel_pmu_lbr_reset_64, .lbr_reset = intel_pmu_lbr_reset_64,
.lbr_read = intel_pmu_lbr_read_64,
}; };
static __initconst const struct x86_pmu intel_pmu = { static __initconst const struct x86_pmu intel_pmu = {
...@@ -4027,6 +4028,7 @@ static __initconst const struct x86_pmu intel_pmu = { ...@@ -4027,6 +4028,7 @@ static __initconst const struct x86_pmu intel_pmu = {
.aux_output_match = intel_pmu_aux_output_match, .aux_output_match = intel_pmu_aux_output_match,
.lbr_reset = intel_pmu_lbr_reset_64, .lbr_reset = intel_pmu_lbr_reset_64,
.lbr_read = intel_pmu_lbr_read_64,
}; };
static __init void intel_clovertown_quirk(void) static __init void intel_clovertown_quirk(void)
...@@ -4653,8 +4655,10 @@ __init int intel_pmu_init(void) ...@@ -4653,8 +4655,10 @@ __init int intel_pmu_init(void)
x86_pmu.intel_cap.capabilities = capabilities; x86_pmu.intel_cap.capabilities = capabilities;
} }
if (x86_pmu.intel_cap.lbr_format == LBR_FORMAT_32) if (x86_pmu.intel_cap.lbr_format == LBR_FORMAT_32) {
x86_pmu.lbr_reset = intel_pmu_lbr_reset_32; x86_pmu.lbr_reset = intel_pmu_lbr_reset_32;
x86_pmu.lbr_read = intel_pmu_lbr_read_32;
}
intel_ds_init(); intel_ds_init();
......
...@@ -562,7 +562,7 @@ void intel_pmu_lbr_disable_all(void) ...@@ -562,7 +562,7 @@ void intel_pmu_lbr_disable_all(void)
__intel_pmu_lbr_disable(); __intel_pmu_lbr_disable();
} }
static void intel_pmu_lbr_read_32(struct cpu_hw_events *cpuc) void intel_pmu_lbr_read_32(struct cpu_hw_events *cpuc)
{ {
unsigned long mask = x86_pmu.lbr_nr - 1; unsigned long mask = x86_pmu.lbr_nr - 1;
u64 tos = intel_pmu_lbr_tos(); u64 tos = intel_pmu_lbr_tos();
...@@ -599,7 +599,7 @@ static void intel_pmu_lbr_read_32(struct cpu_hw_events *cpuc) ...@@ -599,7 +599,7 @@ static void intel_pmu_lbr_read_32(struct cpu_hw_events *cpuc)
* is the same as the linear address, allowing us to merge the LIP and EIP * is the same as the linear address, allowing us to merge the LIP and EIP
* LBR formats. * LBR formats.
*/ */
static void intel_pmu_lbr_read_64(struct cpu_hw_events *cpuc) void intel_pmu_lbr_read_64(struct cpu_hw_events *cpuc)
{ {
bool need_info = false, call_stack = false; bool need_info = false, call_stack = false;
unsigned long mask = x86_pmu.lbr_nr - 1; unsigned long mask = x86_pmu.lbr_nr - 1;
...@@ -704,10 +704,7 @@ void intel_pmu_lbr_read(void) ...@@ -704,10 +704,7 @@ void intel_pmu_lbr_read(void)
cpuc->lbr_users == cpuc->lbr_pebs_users) cpuc->lbr_users == cpuc->lbr_pebs_users)
return; return;
if (x86_pmu.intel_cap.lbr_format == LBR_FORMAT_32) x86_pmu.lbr_read(cpuc);
intel_pmu_lbr_read_32(cpuc);
else
intel_pmu_lbr_read_64(cpuc);
intel_pmu_lbr_filter(cpuc); intel_pmu_lbr_filter(cpuc);
} }
......
...@@ -694,6 +694,7 @@ struct x86_pmu { ...@@ -694,6 +694,7 @@ struct x86_pmu {
bool lbr_pt_coexist; /* (LBR|BTS) may coexist with PT */ bool lbr_pt_coexist; /* (LBR|BTS) may coexist with PT */
void (*lbr_reset)(void); void (*lbr_reset)(void);
void (*lbr_read)(struct cpu_hw_events *cpuc);
/* /*
* Intel PT/LBR/BTS are exclusive * Intel PT/LBR/BTS are exclusive
...@@ -1085,6 +1086,10 @@ void intel_pmu_lbr_disable_all(void); ...@@ -1085,6 +1086,10 @@ void intel_pmu_lbr_disable_all(void);
void intel_pmu_lbr_read(void); void intel_pmu_lbr_read(void);
void intel_pmu_lbr_read_32(struct cpu_hw_events *cpuc);
void intel_pmu_lbr_read_64(struct cpu_hw_events *cpuc);
void intel_pmu_lbr_init_core(void); void intel_pmu_lbr_init_core(void);
void intel_pmu_lbr_init_nhm(void); void intel_pmu_lbr_init_nhm(void);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment