Commit c314c319 authored by James Simmons's avatar James Simmons Committed by Greg Kroah-Hartman

staging: lustre: align all code properly for LNet core

In several places in the LNet core the code doesn't align
up properly. This resolves those checkpath issues.
Signed-off-by: default avatarJames Simmons <jsimmons@infradead.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 4420cfd3
...@@ -1581,8 +1581,7 @@ int kiblnd_fmr_pool_map(kib_fmr_poolset_t *fps, __u64 *pages, int npages, ...@@ -1581,8 +1581,7 @@ int kiblnd_fmr_pool_map(kib_fmr_poolset_t *fps, __u64 *pages, int npages,
if (fps->fps_increasing) { if (fps->fps_increasing) {
spin_unlock(&fps->fps_lock); spin_unlock(&fps->fps_lock);
CDEBUG(D_NET, CDEBUG(D_NET, "Another thread is allocating new FMR pool, waiting for her to complete\n");
"Another thread is allocating new FMR pool, waiting for her to complete\n");
schedule(); schedule();
goto again; goto again;
...@@ -2252,8 +2251,7 @@ int kiblnd_dev_failover(kib_dev_t *dev) ...@@ -2252,8 +2251,7 @@ int kiblnd_dev_failover(kib_dev_t *dev)
int i; int i;
LASSERT(*kiblnd_tunables.kib_dev_failover > 1 || LASSERT(*kiblnd_tunables.kib_dev_failover > 1 ||
dev->ibd_can_failover || dev->ibd_can_failover || dev->ibd_hdev == NULL);
dev->ibd_hdev == NULL);
rc = kiblnd_dev_need_failover(dev); rc = kiblnd_dev_need_failover(dev);
if (rc <= 0) if (rc <= 0)
...@@ -2432,8 +2430,7 @@ static kib_dev_t *kiblnd_create_dev(char *ifname) ...@@ -2432,8 +2430,7 @@ static kib_dev_t *kiblnd_create_dev(char *ifname)
return NULL; return NULL;
} }
list_add_tail(&dev->ibd_list, list_add_tail(&dev->ibd_list, &kiblnd_data.kib_devs);
&kiblnd_data.kib_devs);
return dev; return dev;
} }
......
...@@ -1944,8 +1944,7 @@ kiblnd_abort_txs(kib_conn_t *conn, struct list_head *txs) ...@@ -1944,8 +1944,7 @@ kiblnd_abort_txs(kib_conn_t *conn, struct list_head *txs)
if (txs == &conn->ibc_active_txs) { if (txs == &conn->ibc_active_txs) {
LASSERT(!tx->tx_queued); LASSERT(!tx->tx_queued);
LASSERT(tx->tx_waiting || LASSERT(tx->tx_waiting || tx->tx_sending != 0);
tx->tx_sending != 0);
} else { } else {
LASSERT(tx->tx_queued); LASSERT(tx->tx_queued);
} }
...@@ -3061,8 +3060,7 @@ kiblnd_check_conns(int idx) ...@@ -3061,8 +3060,7 @@ kiblnd_check_conns(int idx)
conn->ibc_reserved_credits); conn->ibc_reserved_credits);
list_add(&conn->ibc_connd_list, &closes); list_add(&conn->ibc_connd_list, &closes);
} else { } else {
list_add(&conn->ibc_connd_list, list_add(&conn->ibc_connd_list, &checksends);
&checksends);
} }
/* +ref for 'closes' or 'checksends' */ /* +ref for 'closes' or 'checksends' */
kiblnd_conn_addref(conn); kiblnd_conn_addref(conn);
...@@ -3090,8 +3088,7 @@ kiblnd_check_conns(int idx) ...@@ -3090,8 +3088,7 @@ kiblnd_check_conns(int idx)
* free to do it last time... * free to do it last time...
*/ */
while (!list_empty(&checksends)) { while (!list_empty(&checksends)) {
conn = list_entry(checksends.next, conn = list_entry(checksends.next, kib_conn_t, ibc_connd_list);
kib_conn_t, ibc_connd_list);
list_del(&conn->ibc_connd_list); list_del(&conn->ibc_connd_list);
kiblnd_check_sends(conn); kiblnd_check_sends(conn);
kiblnd_conn_decref(conn); kiblnd_conn_decref(conn);
...@@ -3350,8 +3347,8 @@ kiblnd_scheduler(void *arg) ...@@ -3350,8 +3347,8 @@ kiblnd_scheduler(void *arg)
did_something = 0; did_something = 0;
if (!list_empty(&sched->ibs_conns)) { if (!list_empty(&sched->ibs_conns)) {
conn = list_entry(sched->ibs_conns.next, conn = list_entry(sched->ibs_conns.next, kib_conn_t,
kib_conn_t, ibc_sched_list); ibc_sched_list);
/* take over kib_sched_conns' ref on conn... */ /* take over kib_sched_conns' ref on conn... */
LASSERT(conn->ibc_scheduled); LASSERT(conn->ibc_scheduled);
list_del(&conn->ibc_sched_list); list_del(&conn->ibc_sched_list);
......
...@@ -592,8 +592,7 @@ ksocknal_del_peer(lnet_ni_t *ni, lnet_process_id_t id, __u32 ip) ...@@ -592,8 +592,7 @@ ksocknal_del_peer(lnet_ni_t *ni, lnet_process_id_t id, __u32 ip)
} }
for (i = lo; i <= hi; i++) { for (i = lo; i <= hi; i++) {
list_for_each_safe(ptmp, pnxt, list_for_each_safe(ptmp, pnxt, &ksocknal_data.ksnd_peers[i]) {
&ksocknal_data.ksnd_peers[i]) {
peer = list_entry(ptmp, ksock_peer_t, ksnp_list); peer = list_entry(ptmp, ksock_peer_t, ksnp_list);
if (peer->ksnp_ni != ni) if (peer->ksnp_ni != ni)
...@@ -2022,8 +2021,7 @@ ksocknal_add_interface(lnet_ni_t *ni, __u32 ipaddress, __u32 netmask) ...@@ -2022,8 +2021,7 @@ ksocknal_add_interface(lnet_ni_t *ni, __u32 ipaddress, __u32 netmask)
iface->ksni_npeers++; iface->ksni_npeers++;
list_for_each(rtmp, &peer->ksnp_routes) { list_for_each(rtmp, &peer->ksnp_routes) {
route = list_entry(rtmp, route = list_entry(rtmp, ksock_route_t,
ksock_route_t,
ksnr_list); ksnr_list);
if (route->ksnr_myipaddr == ipaddress) if (route->ksnr_myipaddr == ipaddress)
...@@ -2114,8 +2112,7 @@ ksocknal_del_interface(lnet_ni_t *ni, __u32 ipaddress) ...@@ -2114,8 +2112,7 @@ ksocknal_del_interface(lnet_ni_t *ni, __u32 ipaddress)
for (j = 0; j < ksocknal_data.ksnd_peer_hash_size; j++) { for (j = 0; j < ksocknal_data.ksnd_peer_hash_size; j++) {
list_for_each_safe(tmp, nxt, list_for_each_safe(tmp, nxt,
&ksocknal_data.ksnd_peers[j]) { &ksocknal_data.ksnd_peers[j]) {
peer = list_entry(tmp, ksock_peer_t, peer = list_entry(tmp, ksock_peer_t, ksnp_list);
ksnp_list);
if (peer->ksnp_ni != ni) if (peer->ksnp_ni != ni)
continue; continue;
...@@ -2712,8 +2709,7 @@ ksocknal_search_new_ipif(ksock_net_t *net) ...@@ -2712,8 +2709,7 @@ ksocknal_search_new_ipif(ksock_net_t *net)
if (colon != NULL) /* ignore alias device */ if (colon != NULL) /* ignore alias device */
*colon = 0; *colon = 0;
list_for_each_entry(tmp, &ksocknal_data.ksnd_nets, list_for_each_entry(tmp, &ksocknal_data.ksnd_nets, ksnn_list) {
ksnn_list) {
for (j = 0; !found && j < tmp->ksnn_ninterfaces; j++) { for (j = 0; !found && j < tmp->ksnn_ninterfaces; j++) {
char *ifnam2 = char *ifnam2 =
&tmp->ksnn_interfaces[j].ksni_name[0]; &tmp->ksnn_interfaces[j].ksni_name[0];
......
...@@ -709,8 +709,7 @@ ksocknal_queue_tx_locked (ksock_tx_t *tx, ksock_conn_t *conn) ...@@ -709,8 +709,7 @@ ksocknal_queue_tx_locked (ksock_tx_t *tx, ksock_conn_t *conn)
CDEBUG(D_NET, "Sending to %s ip %pI4h:%d\n", CDEBUG(D_NET, "Sending to %s ip %pI4h:%d\n",
libcfs_id2str(conn->ksnc_peer->ksnp_id), libcfs_id2str(conn->ksnc_peer->ksnp_id),
&conn->ksnc_ipaddr, &conn->ksnc_ipaddr, conn->ksnc_port);
conn->ksnc_port);
ksocknal_tx_prep(conn, tx); ksocknal_tx_prep(conn, tx);
...@@ -782,8 +781,7 @@ ksocknal_queue_tx_locked (ksock_tx_t *tx, ksock_conn_t *conn) ...@@ -782,8 +781,7 @@ ksocknal_queue_tx_locked (ksock_tx_t *tx, ksock_conn_t *conn)
!conn->ksnc_tx_scheduled) { /* not scheduled to send */ !conn->ksnc_tx_scheduled) { /* not scheduled to send */
/* +1 ref for scheduler */ /* +1 ref for scheduler */
ksocknal_conn_addref(conn); ksocknal_conn_addref(conn);
list_add_tail (&conn->ksnc_tx_list, list_add_tail(&conn->ksnc_tx_list, &sched->kss_tx_conns);
&sched->kss_tx_conns);
conn->ksnc_tx_scheduled = 1; conn->ksnc_tx_scheduled = 1;
wake_up (&sched->kss_waitq); wake_up (&sched->kss_waitq);
} }
...@@ -1468,7 +1466,7 @@ int ksocknal_scheduler(void *arg) ...@@ -1468,7 +1466,7 @@ int ksocknal_scheduler(void *arg)
conn->ksnc_rx_state = SOCKNAL_RX_PARSE_WAIT; conn->ksnc_rx_state = SOCKNAL_RX_PARSE_WAIT;
} else if (conn->ksnc_rx_ready) { } else if (conn->ksnc_rx_ready) {
/* reschedule for rx */ /* reschedule for rx */
list_add_tail (&conn->ksnc_rx_list, list_add_tail(&conn->ksnc_rx_list,
&sched->kss_rx_conns); &sched->kss_rx_conns);
} else { } else {
conn->ksnc_rx_scheduled = 0; conn->ksnc_rx_scheduled = 0;
...@@ -1483,8 +1481,7 @@ int ksocknal_scheduler(void *arg) ...@@ -1483,8 +1481,7 @@ int ksocknal_scheduler(void *arg)
LIST_HEAD(zlist); LIST_HEAD(zlist);
if (!list_empty(&sched->kss_zombie_noop_txs)) { if (!list_empty(&sched->kss_zombie_noop_txs)) {
list_add(&zlist, list_add(&zlist, &sched->kss_zombie_noop_txs);
&sched->kss_zombie_noop_txs);
list_del_init(&sched->kss_zombie_noop_txs); list_del_init(&sched->kss_zombie_noop_txs);
} }
...@@ -1527,8 +1524,7 @@ int ksocknal_scheduler(void *arg) ...@@ -1527,8 +1524,7 @@ int ksocknal_scheduler(void *arg)
if (rc == -ENOMEM || rc == -EAGAIN) { if (rc == -ENOMEM || rc == -EAGAIN) {
/* Incomplete send: replace tx on HEAD of tx_queue */ /* Incomplete send: replace tx on HEAD of tx_queue */
spin_lock_bh(&sched->kss_lock); spin_lock_bh(&sched->kss_lock);
list_add(&tx->tx_list, list_add(&tx->tx_list, &conn->ksnc_tx_queue);
&conn->ksnc_tx_queue);
} else { } else {
/* Complete send; tx -ref */ /* Complete send; tx -ref */
ksocknal_tx_decref(tx); ksocknal_tx_decref(tx);
...@@ -1595,8 +1591,7 @@ void ksocknal_read_callback (ksock_conn_t *conn) ...@@ -1595,8 +1591,7 @@ void ksocknal_read_callback (ksock_conn_t *conn)
conn->ksnc_rx_ready = 1; conn->ksnc_rx_ready = 1;
if (!conn->ksnc_rx_scheduled) { /* not being progressed */ if (!conn->ksnc_rx_scheduled) { /* not being progressed */
list_add_tail(&conn->ksnc_rx_list, list_add_tail(&conn->ksnc_rx_list, &sched->kss_rx_conns);
&sched->kss_rx_conns);
conn->ksnc_rx_scheduled = 1; conn->ksnc_rx_scheduled = 1;
/* extra ref for scheduler */ /* extra ref for scheduler */
ksocknal_conn_addref(conn); ksocknal_conn_addref(conn);
...@@ -1622,8 +1617,7 @@ void ksocknal_write_callback (ksock_conn_t *conn) ...@@ -1622,8 +1617,7 @@ void ksocknal_write_callback (ksock_conn_t *conn)
if (!conn->ksnc_tx_scheduled && /* not being progressed */ if (!conn->ksnc_tx_scheduled && /* not being progressed */
!list_empty(&conn->ksnc_tx_queue)) { /* packets to send */ !list_empty(&conn->ksnc_tx_queue)) { /* packets to send */
list_add_tail (&conn->ksnc_tx_list, list_add_tail(&conn->ksnc_tx_list, &sched->kss_tx_conns);
&sched->kss_tx_conns);
conn->ksnc_tx_scheduled = 1; conn->ksnc_tx_scheduled = 1;
/* extra ref for scheduler */ /* extra ref for scheduler */
ksocknal_conn_addref(conn); ksocknal_conn_addref(conn);
...@@ -1850,8 +1844,7 @@ ksocknal_recv_hello (lnet_ni_t *ni, ksock_conn_t *conn, ...@@ -1850,8 +1844,7 @@ ksocknal_recv_hello (lnet_ni_t *ni, ksock_conn_t *conn,
if (ksocknal_invert_type(hello->kshm_ctype) != conn->ksnc_type) { if (ksocknal_invert_type(hello->kshm_ctype) != conn->ksnc_type) {
CERROR("Mismatched types: me %d, %s ip %pI4h %d\n", CERROR("Mismatched types: me %d, %s ip %pI4h %d\n",
conn->ksnc_type, libcfs_id2str(*peerid), conn->ksnc_type, libcfs_id2str(*peerid),
&conn->ksnc_ipaddr, &conn->ksnc_ipaddr, hello->kshm_ctype);
hello->kshm_ctype);
return -EPROTO; return -EPROTO;
} }
...@@ -2152,7 +2145,7 @@ ksocknal_connd_get_route_locked(signed long *timeout_p) ...@@ -2152,7 +2145,7 @@ ksocknal_connd_get_route_locked(signed long *timeout_p)
now = cfs_time_current(); now = cfs_time_current();
/* connd_routes can contain both pending and ordinary routes */ /* connd_routes can contain both pending and ordinary routes */
list_for_each_entry (route, &ksocknal_data.ksnd_connd_routes, list_for_each_entry(route, &ksocknal_data.ksnd_connd_routes,
ksnr_connd_list) { ksnr_connd_list) {
if (route->ksnr_retry_interval == 0 || if (route->ksnr_retry_interval == 0 ||
...@@ -2372,8 +2365,7 @@ ksocknal_flush_stale_txs(ksock_peer_t *peer) ...@@ -2372,8 +2365,7 @@ ksocknal_flush_stale_txs(ksock_peer_t *peer)
write_lock_bh(&ksocknal_data.ksnd_global_lock); write_lock_bh(&ksocknal_data.ksnd_global_lock);
while (!list_empty (&peer->ksnp_tx_queue)) { while (!list_empty (&peer->ksnp_tx_queue)) {
tx = list_entry (peer->ksnp_tx_queue.next, tx = list_entry(peer->ksnp_tx_queue.next, ksock_tx_t, tx_list);
ksock_tx_t, tx_list);
if (!cfs_time_aftereq(cfs_time_current(), if (!cfs_time_aftereq(cfs_time_current(),
tx->tx_deadline)) tx->tx_deadline))
...@@ -2498,8 +2490,7 @@ ksocknal_check_peer_timeouts (int idx) ...@@ -2498,8 +2490,7 @@ ksocknal_check_peer_timeouts (int idx)
* holding only shared lock * holding only shared lock
*/ */
if (!list_empty (&peer->ksnp_tx_queue)) { if (!list_empty (&peer->ksnp_tx_queue)) {
ksock_tx_t *tx = ksock_tx_t *tx = list_entry(peer->ksnp_tx_queue.next,
list_entry (peer->ksnp_tx_queue.next,
ksock_tx_t, tx_list); ksock_tx_t, tx_list);
if (cfs_time_aftereq(cfs_time_current(), if (cfs_time_aftereq(cfs_time_current(),
...@@ -2618,8 +2609,8 @@ ksocknal_reaper (void *arg) ...@@ -2618,8 +2609,8 @@ ksocknal_reaper (void *arg)
/* reschedule all the connections that stalled with ENOMEM... */ /* reschedule all the connections that stalled with ENOMEM... */
nenomem_conns = 0; nenomem_conns = 0;
while (!list_empty (&enomem_conns)) { while (!list_empty (&enomem_conns)) {
conn = list_entry (enomem_conns.next, conn = list_entry(enomem_conns.next, ksock_conn_t,
ksock_conn_t, ksnc_tx_list); ksnc_tx_list);
list_del (&conn->ksnc_tx_list); list_del (&conn->ksnc_tx_list);
sched = conn->ksnc_scheduler; sched = conn->ksnc_scheduler;
......
...@@ -198,8 +198,8 @@ ksocknal_lib_eager_ack(ksock_conn_t *conn) ...@@ -198,8 +198,8 @@ ksocknal_lib_eager_ack(ksock_conn_t *conn)
* on, introducing delay in completing zero-copy sends in my * on, introducing delay in completing zero-copy sends in my
* peer. * peer.
*/ */
kernel_setsockopt(sock, SOL_TCP, TCP_QUICKACK, kernel_setsockopt(sock, SOL_TCP, TCP_QUICKACK, (char *)&opt,
(char *)&opt, sizeof(opt)); sizeof(opt));
} }
int int
...@@ -236,8 +236,8 @@ ksocknal_lib_recv_iov(ksock_conn_t *conn) ...@@ -236,8 +236,8 @@ ksocknal_lib_recv_iov(ksock_conn_t *conn)
} }
LASSERT(nob <= conn->ksnc_rx_nob_wanted); LASSERT(nob <= conn->ksnc_rx_nob_wanted);
rc = kernel_recvmsg(conn->ksnc_sock, &msg, rc = kernel_recvmsg(conn->ksnc_sock, &msg, scratchiov, niov, nob,
scratchiov, niov, nob, MSG_DONTWAIT); MSG_DONTWAIT);
saved_csum = 0; saved_csum = 0;
if (conn->ksnc_proto == &ksocknal_protocol_v2x) { if (conn->ksnc_proto == &ksocknal_protocol_v2x) {
...@@ -357,8 +357,8 @@ ksocknal_lib_recv_kiov(ksock_conn_t *conn) ...@@ -357,8 +357,8 @@ ksocknal_lib_recv_kiov(ksock_conn_t *conn)
LASSERT(nob <= conn->ksnc_rx_nob_wanted); LASSERT(nob <= conn->ksnc_rx_nob_wanted);
rc = kernel_recvmsg(conn->ksnc_sock, &msg, rc = kernel_recvmsg(conn->ksnc_sock, &msg, (struct kvec *)scratchiov,
(struct kvec *)scratchiov, n, nob, MSG_DONTWAIT); n, nob, MSG_DONTWAIT);
if (conn->ksnc_msg.ksm_csum != 0) { if (conn->ksnc_msg.ksm_csum != 0) {
for (i = 0, sum = rc; sum > 0; i++, sum -= fragnob) { for (i = 0, sum = rc; sum > 0; i++, sum -= fragnob) {
...@@ -482,16 +482,16 @@ ksocknal_lib_setup_sock(struct socket *sock) ...@@ -482,16 +482,16 @@ ksocknal_lib_setup_sock(struct socket *sock)
linger.l_onoff = 0; linger.l_onoff = 0;
linger.l_linger = 0; linger.l_linger = 0;
rc = kernel_setsockopt(sock, SOL_SOCKET, SO_LINGER, rc = kernel_setsockopt(sock, SOL_SOCKET, SO_LINGER, (char *)&linger,
(char *)&linger, sizeof(linger)); sizeof(linger));
if (rc != 0) { if (rc != 0) {
CERROR("Can't set SO_LINGER: %d\n", rc); CERROR("Can't set SO_LINGER: %d\n", rc);
return rc; return rc;
} }
option = -1; option = -1;
rc = kernel_setsockopt(sock, SOL_TCP, TCP_LINGER2, rc = kernel_setsockopt(sock, SOL_TCP, TCP_LINGER2, (char *)&option,
(char *)&option, sizeof(option)); sizeof(option));
if (rc != 0) { if (rc != 0) {
CERROR("Can't set SO_LINGER2: %d\n", rc); CERROR("Can't set SO_LINGER2: %d\n", rc);
return rc; return rc;
...@@ -527,8 +527,8 @@ ksocknal_lib_setup_sock(struct socket *sock) ...@@ -527,8 +527,8 @@ ksocknal_lib_setup_sock(struct socket *sock)
do_keepalive = (keep_idle > 0 && keep_count > 0 && keep_intvl > 0); do_keepalive = (keep_idle > 0 && keep_count > 0 && keep_intvl > 0);
option = (do_keepalive ? 1 : 0); option = (do_keepalive ? 1 : 0);
rc = kernel_setsockopt(sock, SOL_SOCKET, SO_KEEPALIVE, rc = kernel_setsockopt(sock, SOL_SOCKET, SO_KEEPALIVE, (char *)&option,
(char *)&option, sizeof(option)); sizeof(option));
if (rc != 0) { if (rc != 0) {
CERROR("Can't set SO_KEEPALIVE: %d\n", rc); CERROR("Can't set SO_KEEPALIVE: %d\n", rc);
return rc; return rc;
...@@ -537,8 +537,8 @@ ksocknal_lib_setup_sock(struct socket *sock) ...@@ -537,8 +537,8 @@ ksocknal_lib_setup_sock(struct socket *sock)
if (!do_keepalive) if (!do_keepalive)
return 0; return 0;
rc = kernel_setsockopt(sock, SOL_TCP, TCP_KEEPIDLE, rc = kernel_setsockopt(sock, SOL_TCP, TCP_KEEPIDLE, (char *)&keep_idle,
(char *)&keep_idle, sizeof(keep_idle)); sizeof(keep_idle));
if (rc != 0) { if (rc != 0) {
CERROR("Can't set TCP_KEEPIDLE: %d\n", rc); CERROR("Can't set TCP_KEEPIDLE: %d\n", rc);
return rc; return rc;
...@@ -551,8 +551,8 @@ ksocknal_lib_setup_sock(struct socket *sock) ...@@ -551,8 +551,8 @@ ksocknal_lib_setup_sock(struct socket *sock)
return rc; return rc;
} }
rc = kernel_setsockopt(sock, SOL_TCP, TCP_KEEPCNT, rc = kernel_setsockopt(sock, SOL_TCP, TCP_KEEPCNT, (char *)&keep_count,
(char *)&keep_count, sizeof(keep_count)); sizeof(keep_count));
if (rc != 0) { if (rc != 0) {
CERROR("Can't set TCP_KEEPCNT: %d\n", rc); CERROR("Can't set TCP_KEEPCNT: %d\n", rc);
return rc; return rc;
......
...@@ -424,8 +424,8 @@ ksocknal_handle_zcack(ksock_conn_t *conn, __u64 cookie1, __u64 cookie2) ...@@ -424,8 +424,8 @@ ksocknal_handle_zcack(ksock_conn_t *conn, __u64 cookie1, __u64 cookie2)
spin_lock(&peer->ksnp_lock); spin_lock(&peer->ksnp_lock);
list_for_each_entry_safe(tx, tmp, list_for_each_entry_safe(tx, tmp, &peer->ksnp_zc_req_list,
&peer->ksnp_zc_req_list, tx_zc_list) { tx_zc_list) {
__u64 c = tx->tx_msg.ksm_zc_cookies[0]; __u64 c = tx->tx_msg.ksm_zc_cookies[0];
if (c == cookie1 || c == cookie2 || (cookie1 < c && c < cookie2)) { if (c == cookie1 || c == cookie2 || (cookie1 < c && c < cookie2)) {
......
...@@ -542,8 +542,7 @@ lnet_str2tbs_expand(struct list_head *tbs, char *str) ...@@ -542,8 +542,7 @@ lnet_str2tbs_expand(struct list_head *tbs, char *str)
if (sscanf(parsed, "%d-%d%n", &lo, &hi, &scanned) < 2) { if (sscanf(parsed, "%d-%d%n", &lo, &hi, &scanned) < 2) {
/* simple string enumeration */ /* simple string enumeration */
if (lnet_expand1tb( if (lnet_expand1tb(&pending, str, sep, sep2,
&pending, str, sep, sep2,
parsed, parsed,
(int)(enditem - parsed)) != 0) { (int)(enditem - parsed)) != 0) {
goto failed; goto failed;
......
...@@ -432,8 +432,7 @@ lnet_check_routes(void) ...@@ -432,8 +432,7 @@ lnet_check_routes(void)
lnet_nid_t nid2; lnet_nid_t nid2;
int net; int net;
route = list_entry(e2, lnet_route_t, route = list_entry(e2, lnet_route_t, lr_list);
lr_list);
if (route2 == NULL) { if (route2 == NULL) {
route2 = route; route2 = route;
...@@ -565,8 +564,7 @@ lnet_get_route(int idx, __u32 *net, __u32 *hops, ...@@ -565,8 +564,7 @@ lnet_get_route(int idx, __u32 *net, __u32 *hops,
rnet = list_entry(e1, lnet_remotenet_t, lrn_list); rnet = list_entry(e1, lnet_remotenet_t, lrn_list);
list_for_each(e2, &rnet->lrn_routes) { list_for_each(e2, &rnet->lrn_routes) {
route = list_entry(e2, lnet_route_t, route = list_entry(e2, lnet_route_t, lr_list);
lr_list);
if (idx-- == 0) { if (idx-- == 0) {
*net = rnet->lrn_net; *net = rnet->lrn_net;
......
...@@ -80,7 +80,8 @@ ...@@ -80,7 +80,8 @@
static int proc_call_handler(void *data, int write, loff_t *ppos, static int proc_call_handler(void *data, int write, loff_t *ppos,
void __user *buffer, size_t *lenp, void __user *buffer, size_t *lenp,
int (*handler)(void *data, int write, int (*handler)(void *data, int write,
loff_t pos, void __user *buffer, int len)) loff_t pos, void __user *buffer,
int len))
{ {
int rc = handler(data, write, *ppos, buffer, *lenp); int rc = handler(data, write, *ppos, buffer, *lenp);
...@@ -740,7 +741,8 @@ static int proc_lnet_nis(struct ctl_table *table, int write, ...@@ -740,7 +741,8 @@ static int proc_lnet_nis(struct ctl_table *table, int write,
ni->ni_peertxcredits, ni->ni_peertxcredits,
ni->ni_peerrtrcredits, ni->ni_peerrtrcredits,
tq->tq_credits_max, tq->tq_credits_max,
tq->tq_credits, tq->tq_credits_min); tq->tq_credits,
tq->tq_credits_min);
if (i != 0) if (i != 0)
lnet_net_unlock(i); lnet_net_unlock(i);
} }
......
...@@ -62,8 +62,7 @@ lst_session_new_ioctl(lstio_session_new_args_t *args) ...@@ -62,8 +62,7 @@ lst_session_new_ioctl(lstio_session_new_args_t *args)
if (name == NULL) if (name == NULL)
return -ENOMEM; return -ENOMEM;
if (copy_from_user(name, if (copy_from_user(name, args->lstio_ses_namep,
args->lstio_ses_namep,
args->lstio_ses_nmlen)) { args->lstio_ses_nmlen)) {
LIBCFS_FREE(name, args->lstio_ses_nmlen + 1); LIBCFS_FREE(name, args->lstio_ses_nmlen + 1);
return -EFAULT; return -EFAULT;
...@@ -212,8 +211,7 @@ lst_group_add_ioctl(lstio_group_add_args_t *args) ...@@ -212,8 +211,7 @@ lst_group_add_ioctl(lstio_group_add_args_t *args)
if (name == NULL) if (name == NULL)
return -ENOMEM; return -ENOMEM;
if (copy_from_user(name, if (copy_from_user(name, args->lstio_grp_namep,
args->lstio_grp_namep,
args->lstio_grp_nmlen)) { args->lstio_grp_nmlen)) {
LIBCFS_FREE(name, args->lstio_grp_nmlen); LIBCFS_FREE(name, args->lstio_grp_nmlen);
return -EFAULT; return -EFAULT;
...@@ -246,8 +244,7 @@ lst_group_del_ioctl(lstio_group_del_args_t *args) ...@@ -246,8 +244,7 @@ lst_group_del_ioctl(lstio_group_del_args_t *args)
if (name == NULL) if (name == NULL)
return -ENOMEM; return -ENOMEM;
if (copy_from_user(name, if (copy_from_user(name, args->lstio_grp_namep,
args->lstio_grp_namep,
args->lstio_grp_nmlen)) { args->lstio_grp_nmlen)) {
LIBCFS_FREE(name, args->lstio_grp_nmlen + 1); LIBCFS_FREE(name, args->lstio_grp_nmlen + 1);
return -EFAULT; return -EFAULT;
...@@ -421,8 +418,7 @@ lst_group_info_ioctl(lstio_group_info_args_t *args) ...@@ -421,8 +418,7 @@ lst_group_info_ioctl(lstio_group_info_args_t *args)
if (name == NULL) if (name == NULL)
return -ENOMEM; return -ENOMEM;
if (copy_from_user(name, if (copy_from_user(name, args->lstio_grp_namep,
args->lstio_grp_namep,
args->lstio_grp_nmlen)) { args->lstio_grp_nmlen)) {
LIBCFS_FREE(name, args->lstio_grp_nmlen + 1); LIBCFS_FREE(name, args->lstio_grp_nmlen + 1);
return -EFAULT; return -EFAULT;
...@@ -464,8 +460,7 @@ lst_batch_add_ioctl(lstio_batch_add_args_t *args) ...@@ -464,8 +460,7 @@ lst_batch_add_ioctl(lstio_batch_add_args_t *args)
if (name == NULL) if (name == NULL)
return -ENOMEM; return -ENOMEM;
if (copy_from_user(name, if (copy_from_user(name, args->lstio_bat_namep,
args->lstio_bat_namep,
args->lstio_bat_nmlen)) { args->lstio_bat_nmlen)) {
LIBCFS_FREE(name, args->lstio_bat_nmlen + 1); LIBCFS_FREE(name, args->lstio_bat_nmlen + 1);
return -EFAULT; return -EFAULT;
...@@ -498,8 +493,7 @@ lst_batch_run_ioctl(lstio_batch_run_args_t *args) ...@@ -498,8 +493,7 @@ lst_batch_run_ioctl(lstio_batch_run_args_t *args)
if (name == NULL) if (name == NULL)
return -ENOMEM; return -ENOMEM;
if (copy_from_user(name, if (copy_from_user(name, args->lstio_bat_namep,
args->lstio_bat_namep,
args->lstio_bat_nmlen)) { args->lstio_bat_nmlen)) {
LIBCFS_FREE(name, args->lstio_bat_nmlen + 1); LIBCFS_FREE(name, args->lstio_bat_nmlen + 1);
return -EFAULT; return -EFAULT;
...@@ -534,8 +528,7 @@ lst_batch_stop_ioctl(lstio_batch_stop_args_t *args) ...@@ -534,8 +528,7 @@ lst_batch_stop_ioctl(lstio_batch_stop_args_t *args)
if (name == NULL) if (name == NULL)
return -ENOMEM; return -ENOMEM;
if (copy_from_user(name, if (copy_from_user(name, args->lstio_bat_namep,
args->lstio_bat_namep,
args->lstio_bat_nmlen)) { args->lstio_bat_nmlen)) {
LIBCFS_FREE(name, args->lstio_bat_nmlen + 1); LIBCFS_FREE(name, args->lstio_bat_nmlen + 1);
return -EFAULT; return -EFAULT;
...@@ -573,8 +566,7 @@ lst_batch_query_ioctl(lstio_batch_query_args_t *args) ...@@ -573,8 +566,7 @@ lst_batch_query_ioctl(lstio_batch_query_args_t *args)
if (name == NULL) if (name == NULL)
return -ENOMEM; return -ENOMEM;
if (copy_from_user(name, if (copy_from_user(name, args->lstio_bat_namep,
args->lstio_bat_namep,
args->lstio_bat_nmlen)) { args->lstio_bat_nmlen)) {
LIBCFS_FREE(name, args->lstio_bat_nmlen + 1); LIBCFS_FREE(name, args->lstio_bat_nmlen + 1);
return -EFAULT; return -EFAULT;
...@@ -649,18 +641,17 @@ lst_batch_info_ioctl(lstio_batch_info_args_t *args) ...@@ -649,18 +641,17 @@ lst_batch_info_ioctl(lstio_batch_info_args_t *args)
if (name == NULL) if (name == NULL)
return -ENOMEM; return -ENOMEM;
if (copy_from_user(name, if (copy_from_user(name, args->lstio_bat_namep,
args->lstio_bat_namep, args->lstio_bat_nmlen)) { args->lstio_bat_nmlen)) {
LIBCFS_FREE(name, args->lstio_bat_nmlen + 1); LIBCFS_FREE(name, args->lstio_bat_nmlen + 1);
return -EFAULT; return -EFAULT;
} }
name[args->lstio_bat_nmlen] = 0; name[args->lstio_bat_nmlen] = 0;
rc = lstcon_batch_info(name, rc = lstcon_batch_info(name, args->lstio_bat_entp,
args->lstio_bat_entp, args->lstio_bat_server, args->lstio_bat_server, args->lstio_bat_testidx,
args->lstio_bat_testidx, &index, &ndent, &index, &ndent, args->lstio_bat_dentsp);
args->lstio_bat_dentsp);
LIBCFS_FREE(name, args->lstio_bat_nmlen + 1); LIBCFS_FREE(name, args->lstio_bat_nmlen + 1);
...@@ -784,10 +775,8 @@ static int lst_test_add_ioctl(lstio_test_args_t *args) ...@@ -784,10 +775,8 @@ static int lst_test_add_ioctl(lstio_test_args_t *args)
args->lstio_tes_param_len)) args->lstio_tes_param_len))
goto out; goto out;
rc = lstcon_test_add(batch_name, rc = lstcon_test_add(batch_name, args->lstio_tes_type,
args->lstio_tes_type, args->lstio_tes_loop, args->lstio_tes_concur,
args->lstio_tes_loop,
args->lstio_tes_concur,
args->lstio_tes_dist, args->lstio_tes_span, args->lstio_tes_dist, args->lstio_tes_span,
src_name, dst_name, param, src_name, dst_name, param,
args->lstio_tes_param_len, args->lstio_tes_param_len,
......
...@@ -510,11 +510,11 @@ lstcon_rpc_trans_interpreter(lstcon_rpc_trans_t *trans, ...@@ -510,11 +510,11 @@ lstcon_rpc_trans_interpreter(lstcon_rpc_trans_t *trans,
(unsigned long)console_session.ses_id.ses_stamp); (unsigned long)console_session.ses_id.ses_stamp);
jiffies_to_timeval(dur, &tv); jiffies_to_timeval(dur, &tv);
if (copy_to_user(&ent->rpe_peer, if (copy_to_user(&ent->rpe_peer, &nd->nd_id,
&nd->nd_id, sizeof(lnet_process_id_t)) || sizeof(lnet_process_id_t)) ||
copy_to_user(&ent->rpe_stamp, &tv, sizeof(tv)) || copy_to_user(&ent->rpe_stamp, &tv, sizeof(tv)) ||
copy_to_user(&ent->rpe_state, copy_to_user(&ent->rpe_state, &nd->nd_state,
&nd->nd_state, sizeof(nd->nd_state)) || sizeof(nd->nd_state)) ||
copy_to_user(&ent->rpe_rpc_errno, &error, copy_to_user(&ent->rpe_rpc_errno, &error,
sizeof(error))) sizeof(error)))
return -EFAULT; return -EFAULT;
...@@ -525,10 +525,9 @@ lstcon_rpc_trans_interpreter(lstcon_rpc_trans_t *trans, ...@@ -525,10 +525,9 @@ lstcon_rpc_trans_interpreter(lstcon_rpc_trans_t *trans,
/* RPC is done */ /* RPC is done */
rep = (srpc_generic_reply_t *)&msg->msg_body.reply; rep = (srpc_generic_reply_t *)&msg->msg_body.reply;
if (copy_to_user(&ent->rpe_sid, if (copy_to_user(&ent->rpe_sid, &rep->sid, sizeof(lst_sid_t)) ||
&rep->sid, sizeof(lst_sid_t)) || copy_to_user(&ent->rpe_fwk_errno, &rep->status,
copy_to_user(&ent->rpe_fwk_errno, sizeof(rep->status)))
&rep->status, sizeof(rep->status)))
return -EFAULT; return -EFAULT;
if (readent == NULL) if (readent == NULL)
......
...@@ -1382,8 +1382,8 @@ lstcon_tsbrpc_readent(int transop, srpc_msg_t *msg, ...@@ -1382,8 +1382,8 @@ lstcon_tsbrpc_readent(int transop, srpc_msg_t *msg,
transop == LST_TRANS_TSBSRVQRY); transop == LST_TRANS_TSBSRVQRY);
/* positive errno, framework error code */ /* positive errno, framework error code */
if (copy_to_user(&ent_up->rpe_priv[0], if (copy_to_user(&ent_up->rpe_priv[0], &rep->bar_active,
&rep->bar_active, sizeof(rep->bar_active))) sizeof(rep->bar_active)))
return -EFAULT; return -EFAULT;
return 0; return 0;
......
...@@ -289,8 +289,7 @@ sfw_server_rpc_done(struct srpc_server_rpc *rpc) ...@@ -289,8 +289,7 @@ sfw_server_rpc_done(struct srpc_server_rpc *rpc)
struct srpc_service *sv = rpc->srpc_scd->scd_svc; struct srpc_service *sv = rpc->srpc_scd->scd_svc;
int status = rpc->srpc_status; int status = rpc->srpc_status;
CDEBUG(D_NET, CDEBUG(D_NET, "Incoming framework RPC done: service %s, peer %s, status %s:%d\n",
"Incoming framework RPC done: service %s, peer %s, status %s:%d\n",
sv->sv_name, libcfs_id2str(rpc->srpc_peer), sv->sv_name, libcfs_id2str(rpc->srpc_peer),
swi_state2str(rpc->srpc_wi.swi_state), swi_state2str(rpc->srpc_wi.swi_state),
status); status);
...@@ -307,8 +306,7 @@ sfw_client_rpc_fini(srpc_client_rpc_t *rpc) ...@@ -307,8 +306,7 @@ sfw_client_rpc_fini(srpc_client_rpc_t *rpc)
LASSERT(list_empty(&rpc->crpc_list)); LASSERT(list_empty(&rpc->crpc_list));
LASSERT(atomic_read(&rpc->crpc_refcount) == 0); LASSERT(atomic_read(&rpc->crpc_refcount) == 0);
CDEBUG(D_NET, CDEBUG(D_NET, "Outgoing framework RPC done: service %d, peer %s, status %s:%d:%d\n",
"Outgoing framework RPC done: service %d, peer %s, status %s:%d:%d\n",
rpc->crpc_service, libcfs_id2str(rpc->crpc_dest), rpc->crpc_service, libcfs_id2str(rpc->crpc_dest),
swi_state2str(rpc->crpc_wi.swi_state), swi_state2str(rpc->crpc_wi.swi_state),
rpc->crpc_aborted, rpc->crpc_status); rpc->crpc_aborted, rpc->crpc_status);
......
...@@ -212,8 +212,7 @@ srpc_service_fini(struct srpc_service *svc) ...@@ -212,8 +212,7 @@ srpc_service_fini(struct srpc_service *svc)
break; break;
while (!list_empty(q)) { while (!list_empty(q)) {
buf = list_entry(q->next, buf = list_entry(q->next, struct srpc_buffer,
struct srpc_buffer,
buf_list); buf_list);
list_del(&buf->buf_list); list_del(&buf->buf_list);
LIBCFS_FREE(buf, sizeof(*buf)); LIBCFS_FREE(buf, sizeof(*buf));
...@@ -390,8 +389,7 @@ srpc_post_passive_rdma(int portal, int local, __u64 matchbits, void *buf, ...@@ -390,8 +389,7 @@ srpc_post_passive_rdma(int portal, int local, __u64 matchbits, void *buf,
return -ENOMEM; return -ENOMEM;
} }
CDEBUG(D_NET, CDEBUG(D_NET, "Posted passive RDMA: peer %s, portal %d, matchbits %#llx\n",
"Posted passive RDMA: peer %s, portal %d, matchbits %#llx\n",
libcfs_id2str(peer), portal, matchbits); libcfs_id2str(peer), portal, matchbits);
return 0; return 0;
} }
...@@ -444,8 +442,7 @@ srpc_post_active_rdma(int portal, __u64 matchbits, void *buf, int len, ...@@ -444,8 +442,7 @@ srpc_post_active_rdma(int portal, __u64 matchbits, void *buf, int len,
rc = LNetMDUnlink(*mdh); rc = LNetMDUnlink(*mdh);
LASSERT(rc == 0); LASSERT(rc == 0);
} else { } else {
CDEBUG(D_NET, CDEBUG(D_NET, "Posted active RDMA: peer %s, portal %u, matchbits %#llx\n",
"Posted active RDMA: peer %s, portal %u, matchbits %#llx\n",
libcfs_id2str(peer), portal, matchbits); libcfs_id2str(peer), portal, matchbits);
} }
return 0; return 0;
...@@ -1343,8 +1340,7 @@ srpc_abort_rpc(srpc_client_rpc_t *rpc, int why) ...@@ -1343,8 +1340,7 @@ srpc_abort_rpc(srpc_client_rpc_t *rpc, int why)
rpc->crpc_closed) /* callback imminent */ rpc->crpc_closed) /* callback imminent */
return; return;
CDEBUG(D_NET, CDEBUG(D_NET, "Aborting RPC: service %d, peer %s, state %s, why %d\n",
"Aborting RPC: service %d, peer %s, state %s, why %d\n",
rpc->crpc_service, libcfs_id2str(rpc->crpc_dest), rpc->crpc_service, libcfs_id2str(rpc->crpc_dest),
swi_state2str(rpc->crpc_wi.swi_state), why); swi_state2str(rpc->crpc_wi.swi_state), why);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment