Commit c4e5ac0a authored by Dan Williams's avatar Dan Williams Committed by Neil Brown

md: use stripe_head_state in ops_run_io()

From: Dan Williams <dan.j.williams@intel.com>

In handle_stripe after taking sh->lock we sample some bits into 's' (struct
stripe_head_state):

	s.syncing = test_bit(STRIPE_SYNCING, &sh->state);
	s.expanding = test_bit(STRIPE_EXPAND_SOURCE, &sh->state);
	s.expanded = test_bit(STRIPE_EXPAND_READY, &sh->state);

Use these values from 's' in ops_run_io() rather than re-sampling the bits.
This ensures a consistent snapshot (as seen under sh->lock) is used.
Signed-off-by: default avatarDan Williams <dan.j.williams@intel.com>
Signed-off-by: default avatarNeil Brown <neilb@suse.de>
parent 2b7497f0
...@@ -390,7 +390,7 @@ raid5_end_read_request(struct bio *bi, int error); ...@@ -390,7 +390,7 @@ raid5_end_read_request(struct bio *bi, int error);
static void static void
raid5_end_write_request(struct bio *bi, int error); raid5_end_write_request(struct bio *bi, int error);
static void ops_run_io(struct stripe_head *sh) static void ops_run_io(struct stripe_head *sh, struct stripe_head_state *s)
{ {
raid5_conf_t *conf = sh->raid_conf; raid5_conf_t *conf = sh->raid_conf;
int i, disks = sh->disks; int i, disks = sh->disks;
...@@ -425,9 +425,7 @@ static void ops_run_io(struct stripe_head *sh) ...@@ -425,9 +425,7 @@ static void ops_run_io(struct stripe_head *sh)
rcu_read_unlock(); rcu_read_unlock();
if (rdev) { if (rdev) {
if (test_bit(STRIPE_SYNCING, &sh->state) || if (s->syncing || s->expanding || s->expanded)
test_bit(STRIPE_EXPAND_SOURCE, &sh->state) ||
test_bit(STRIPE_EXPAND_READY, &sh->state))
md_sync_acct(rdev->bdev, STRIPE_SECTORS); md_sync_acct(rdev->bdev, STRIPE_SECTORS);
set_bit(STRIPE_IO_STARTED, &sh->state); set_bit(STRIPE_IO_STARTED, &sh->state);
...@@ -2902,10 +2900,9 @@ static void handle_stripe5(struct stripe_head *sh) ...@@ -2902,10 +2900,9 @@ static void handle_stripe5(struct stripe_head *sh)
if (pending) if (pending)
raid5_run_ops(sh, pending); raid5_run_ops(sh, pending);
ops_run_io(sh); ops_run_io(sh, &s);
return_io(return_bi); return_io(return_bi);
} }
static void handle_stripe6(struct stripe_head *sh, struct page *tmp_page) static void handle_stripe6(struct stripe_head *sh, struct page *tmp_page)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment