Commit c53202b9 authored by Aravind Gopalakrishnan's avatar Aravind Gopalakrishnan Committed by Zefan Li

x86/iommu: Fix header comments regarding standard and _FINISH macros

commit b4491592 upstream.

The comment line regarding IOMMU_INIT and IOMMU_INIT_FINISH
macros is incorrect:

  "The standard vs the _FINISH differs in that the _FINISH variant
  will continue detecting other IOMMUs in the call list..."

It should be "..the *standard* variant will continue
detecting..."

Fix that. Also, make it readable while at it.
Signed-off-by: default avatarAravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com>
Signed-off-by: default avatarBorislav Petkov <bp@suse.de>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: konrad.wilk@oracle.com
Fixes: 6e963669 ("x86, iommu: Update header comments with appropriate naming")
Link: http://lkml.kernel.org/r/1428508017-5316-1-git-send-email-Aravind.Gopalakrishnan@amd.comSigned-off-by: default avatarIngo Molnar <mingo@kernel.org>
Signed-off-by: default avatarZefan Li <lizefan@huawei.com>
parent ac18a535
...@@ -79,11 +79,12 @@ struct iommu_table_entry { ...@@ -79,11 +79,12 @@ struct iommu_table_entry {
* d). Similar to the 'init', except that this gets called from pci_iommu_init * d). Similar to the 'init', except that this gets called from pci_iommu_init
* where we do have a memory allocator. * where we do have a memory allocator.
* *
* The standard vs the _FINISH differs in that the _FINISH variant will * The standard IOMMU_INIT differs from the IOMMU_INIT_FINISH variant
* continue detecting other IOMMUs in the call list after the * in that the former will continue detecting other IOMMUs in the call
* the detection routine returns a positive number. The _FINISH will * list after the detection routine returns a positive number, while the
* stop the execution chain. Both will still call the 'init' and * latter will stop the execution chain upon first successful detection.
* 'late_init' functions if they are set. * Both variants will still call the 'init' and 'late_init' functions if
* they are set.
*/ */
#define IOMMU_INIT_FINISH(_detect, _depend, _init, _late_init) \ #define IOMMU_INIT_FINISH(_detect, _depend, _init, _late_init) \
__IOMMU_INIT(_detect, _depend, _init, _late_init, 1) __IOMMU_INIT(_detect, _depend, _init, _late_init, 1)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment