Commit c594c891 authored by Peter Ujfalusi's avatar Peter Ujfalusi Committed by Vinod Koul

dmaengine: edma: Prefix debug prints where the text were identical in prep callbacks

prep_slave_sg and prep_dma_cyclic callbacks have mostly same failure cases
with the same texts printed in case we hit them. It helps when debugging if
we know exactly which callback generated the errors.
At the same time change the debug level for descriptor allocation failure
from dbg to err since all other error cases are dev_err and this failure is
similarly fatal as the other ones.
Signed-off-by: default avatarPeter Ujfalusi <peter.ujfalusi@ti.com>
Acked-by: default avatarJoel Fernandes <joelf@ti.com>
Reviewed-and-Tested-by: default avatarJoel Fernandes <joelf@ti.com>
Signed-off-by: default avatarVinod Koul <vinod.koul@intel.com>
parent 2c88ee6b
...@@ -438,14 +438,14 @@ static struct dma_async_tx_descriptor *edma_prep_slave_sg( ...@@ -438,14 +438,14 @@ static struct dma_async_tx_descriptor *edma_prep_slave_sg(
} }
if (dev_width == DMA_SLAVE_BUSWIDTH_UNDEFINED) { if (dev_width == DMA_SLAVE_BUSWIDTH_UNDEFINED) {
dev_err(dev, "Undefined slave buswidth\n"); dev_err(dev, "%s: Undefined slave buswidth\n", __func__);
return NULL; return NULL;
} }
edesc = kzalloc(sizeof(*edesc) + sg_len * edesc = kzalloc(sizeof(*edesc) + sg_len *
sizeof(edesc->pset[0]), GFP_ATOMIC); sizeof(edesc->pset[0]), GFP_ATOMIC);
if (!edesc) { if (!edesc) {
dev_dbg(dev, "Failed to allocate a descriptor\n"); dev_err(dev, "%s: Failed to allocate a descriptor\n", __func__);
return NULL; return NULL;
} }
...@@ -461,7 +461,8 @@ static struct dma_async_tx_descriptor *edma_prep_slave_sg( ...@@ -461,7 +461,8 @@ static struct dma_async_tx_descriptor *edma_prep_slave_sg(
EDMA_SLOT_ANY); EDMA_SLOT_ANY);
if (echan->slot[i] < 0) { if (echan->slot[i] < 0) {
kfree(edesc); kfree(edesc);
dev_err(dev, "Failed to allocate slot\n"); dev_err(dev, "%s: Failed to allocate slot\n",
__func__);
return NULL; return NULL;
} }
} }
...@@ -530,7 +531,7 @@ static struct dma_async_tx_descriptor *edma_prep_dma_cyclic( ...@@ -530,7 +531,7 @@ static struct dma_async_tx_descriptor *edma_prep_dma_cyclic(
} }
if (dev_width == DMA_SLAVE_BUSWIDTH_UNDEFINED) { if (dev_width == DMA_SLAVE_BUSWIDTH_UNDEFINED) {
dev_err(dev, "Undefined slave buswidth\n"); dev_err(dev, "%s: Undefined slave buswidth\n", __func__);
return NULL; return NULL;
} }
...@@ -555,7 +556,7 @@ static struct dma_async_tx_descriptor *edma_prep_dma_cyclic( ...@@ -555,7 +556,7 @@ static struct dma_async_tx_descriptor *edma_prep_dma_cyclic(
edesc = kzalloc(sizeof(*edesc) + nslots * edesc = kzalloc(sizeof(*edesc) + nslots *
sizeof(edesc->pset[0]), GFP_ATOMIC); sizeof(edesc->pset[0]), GFP_ATOMIC);
if (!edesc) { if (!edesc) {
dev_dbg(dev, "Failed to allocate a descriptor\n"); dev_err(dev, "%s: Failed to allocate a descriptor\n", __func__);
return NULL; return NULL;
} }
...@@ -573,7 +574,8 @@ static struct dma_async_tx_descriptor *edma_prep_dma_cyclic( ...@@ -573,7 +574,8 @@ static struct dma_async_tx_descriptor *edma_prep_dma_cyclic(
EDMA_SLOT_ANY); EDMA_SLOT_ANY);
if (echan->slot[i] < 0) { if (echan->slot[i] < 0) {
kfree(edesc); kfree(edesc);
dev_err(dev, "Failed to allocate slot\n"); dev_err(dev, "%s: Failed to allocate slot\n",
__func__);
return NULL; return NULL;
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment