Commit c5be0b2e authored by Richard Kennedy's avatar Richard Kennedy Committed by Rusty Russell

module: reorder kparam_array to remove alignment padding on 64 bit builds

Reorder structure kparam_array to remove 8 bytes of alignment padding on
64 bit builds, dropping its size from 40 to 32 bytes.

Also update the macro module_param_array_named to initialise the
structure using its member names to allow it to be changed without
touching all its call sites.

'git grep' finds module_param_array in 1037 places so this patch will
save a small amount of data space across many modules.
Signed-off-by: default avatarRichard Kennedy <richard@rsk.demon.co.uk>
Signed-off-by: default avatarRusty Russell <rusty@rustcorp.com.au>
parent a288bd65
...@@ -67,9 +67,9 @@ struct kparam_string { ...@@ -67,9 +67,9 @@ struct kparam_string {
struct kparam_array struct kparam_array
{ {
unsigned int max; unsigned int max;
unsigned int elemsize;
unsigned int *num; unsigned int *num;
const struct kernel_param_ops *ops; const struct kernel_param_ops *ops;
unsigned int elemsize;
void *elem; void *elem;
}; };
...@@ -371,8 +371,9 @@ extern int param_get_invbool(char *buffer, const struct kernel_param *kp); ...@@ -371,8 +371,9 @@ extern int param_get_invbool(char *buffer, const struct kernel_param *kp);
*/ */
#define module_param_array_named(name, array, type, nump, perm) \ #define module_param_array_named(name, array, type, nump, perm) \
static const struct kparam_array __param_arr_##name \ static const struct kparam_array __param_arr_##name \
= { ARRAY_SIZE(array), nump, &param_ops_##type, \ = { .max = ARRAY_SIZE(array), .num = nump, \
sizeof(array[0]), array }; \ .ops = &param_ops_##type, \
.elemsize = sizeof(array[0]), .elem = array }; \
__module_param_call(MODULE_PARAM_PREFIX, name, \ __module_param_call(MODULE_PARAM_PREFIX, name, \
&param_array_ops, \ &param_array_ops, \
.arr = &__param_arr_##name, \ .arr = &__param_arr_##name, \
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment