Commit c7685e47 authored by Roland Dreier's avatar Roland Dreier Committed by Ben Hutchings

target: Don't return success from module_init() if setup fails

commit 0d0f9dfb upstream.

If the call to core_dev_release_virtual_lun0() fails, then nothing
sets ret to anything other than 0, so even though everything is
torn down and freed, target_core_init_configfs() will seem to succeed
and the module will be loaded.  Fix this by passing the return value
on up the chain.
Signed-off-by: default avatarRoland Dreier <roland@purestorage.com>
Signed-off-by: default avatarNicholas Bellinger <nab@linux-iscsi.org>
Signed-off-by: default avatarBen Hutchings <ben@decadent.org.uk>
parent bb3cbd2f
...@@ -3205,7 +3205,8 @@ static int __init target_core_init_configfs(void) ...@@ -3205,7 +3205,8 @@ static int __init target_core_init_configfs(void)
if (ret < 0) if (ret < 0)
goto out; goto out;
if (core_dev_setup_virtual_lun0() < 0) ret = core_dev_setup_virtual_lun0();
if (ret < 0)
goto out; goto out;
return 0; return 0;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment