Commit c7d42f37 authored by Joseph Wright's avatar Joseph Wright Committed by Greg Kroah-Hartman

Staging: pi433: check error after kthread_run()

Error should be checked with IS_ERR after calling kthread_run()
instead of comparing the returned pointer to an int.

Found by sparse warning:

incompatible types for operation (<)
    left side has type struct task_struct *tx_task_struct
    right side has type int
Signed-off-by: default avatarJoseph Wright <rjosephwright@gmail.com>
Reviewed-by: default avatarMarcus Wolf <linux@wolf-entwicklungen.de>
Tested-by: default avatarMarcus Wolf <linux@wolf-entwicklungen.de>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 7de77a39
...@@ -1152,7 +1152,7 @@ static int pi433_probe(struct spi_device *spi) ...@@ -1152,7 +1152,7 @@ static int pi433_probe(struct spi_device *spi)
device->tx_task_struct = kthread_run(pi433_tx_thread, device->tx_task_struct = kthread_run(pi433_tx_thread,
device, device,
"pi433_tx_task"); "pi433_tx_task");
if (device->tx_task_struct < 0) if (IS_ERR(device->tx_task_struct))
{ {
dev_dbg(device->dev, "start of send thread failed"); dev_dbg(device->dev, "start of send thread failed");
goto send_thread_failed; goto send_thread_failed;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment