Commit c8d4dea2 authored by Jia-Ju Bai's avatar Jia-Ju Bai Committed by Marc Kleine-Budde

can: sja1000: Replace mdelay with usleep_range in pcan_add_channels

pcan_add_channels() is never called in atomic context.

pcan_add_channels() is only called by pcan_probe(), which is only set as
".probe" in struct pcmcia_driver.

Despite never getting called from atomic context, pcan_add_channels()
calls mdelay() to busily wait.
This is not necessary and can be replaced with usleep_range() to
avoid busy waiting.

This is found by a static analysis tool named DCNS written by myself.
And I also manually check it.
Signed-off-by: default avatarJia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: default avatarMarc Kleine-Budde <mkl@pengutronix.de>
parent 276b7361
...@@ -530,7 +530,7 @@ static int pcan_add_channels(struct pcan_pccard *card) ...@@ -530,7 +530,7 @@ static int pcan_add_channels(struct pcan_pccard *card)
pcan_write_reg(card, PCC_CCR, ccr); pcan_write_reg(card, PCC_CCR, ccr);
/* wait 2ms before unresetting channels */ /* wait 2ms before unresetting channels */
mdelay(2); usleep_range(2000, 3000);
ccr &= ~PCC_CCR_RST_ALL; ccr &= ~PCC_CCR_RST_ALL;
pcan_write_reg(card, PCC_CCR, ccr); pcan_write_reg(card, PCC_CCR, ccr);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment