Commit c94d1783 authored by Christian Marangi's avatar Christian Marangi Committed by Jakub Kicinski

dt-bindings: net: phy: Make LED active-low property common

Move LED active-low property to common.yaml. This property is currently
defined multiple times by bcm LEDs. This property will now be supported
in a generic way for PHY LEDs with the use of a generic function.

With active-low bool property not defined, active-high is always
assumed.
Signed-off-by: default avatarChristian Marangi <ansuelsmth@gmail.com>
Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Acked-by: default avatarLee Jones <lee@kernel.org>
Reviewed-by: default avatarRob Herring <robh@kernel.org>
Link: https://lore.kernel.org/r/20240125203702.4552-2-ansuelsmth@gmail.comSigned-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 5642c82b
...@@ -200,6 +200,12 @@ properties: ...@@ -200,6 +200,12 @@ properties:
#trigger-source-cells property in the source node. #trigger-source-cells property in the source node.
$ref: /schemas/types.yaml#/definitions/phandle-array $ref: /schemas/types.yaml#/definitions/phandle-array
active-low:
type: boolean
description:
Makes LED active low. To turn the LED ON, line needs to be
set to low voltage instead of high.
# Required properties for flash LED child nodes: # Required properties for flash LED child nodes:
flash-max-microamp: flash-max-microamp:
description: description:
......
...@@ -52,10 +52,6 @@ patternProperties: ...@@ -52,10 +52,6 @@ patternProperties:
maxItems: 1 maxItems: 1
description: LED pin number description: LED pin number
active-low:
type: boolean
description: Makes LED active low
required: required:
- reg - reg
......
...@@ -78,10 +78,6 @@ patternProperties: ...@@ -78,10 +78,6 @@ patternProperties:
- maximum: 23 - maximum: 23
description: LED pin number (only LEDs 0 to 23 are valid). description: LED pin number (only LEDs 0 to 23 are valid).
active-low:
type: boolean
description: Makes LED active low.
brcm,hardware-controlled: brcm,hardware-controlled:
type: boolean type: boolean
description: Makes this LED hardware controlled. description: Makes this LED hardware controlled.
......
...@@ -25,8 +25,6 @@ LED sub-node required properties: ...@@ -25,8 +25,6 @@ LED sub-node required properties:
LED sub-node optional properties: LED sub-node optional properties:
- label : see Documentation/devicetree/bindings/leds/common.txt - label : see Documentation/devicetree/bindings/leds/common.txt
- active-low : Boolean, makes LED active low.
Default : false
- default-state : see - default-state : see
Documentation/devicetree/bindings/leds/common.txt Documentation/devicetree/bindings/leds/common.txt
- linux,default-trigger : see - linux,default-trigger : see
......
...@@ -41,10 +41,6 @@ properties: ...@@ -41,10 +41,6 @@ properties:
pwm-names: true pwm-names: true
active-low:
description: For PWMs where the LED is wired to supply rather than ground.
type: boolean
color: true color: true
required: required:
......
...@@ -34,11 +34,6 @@ patternProperties: ...@@ -34,11 +34,6 @@ patternProperties:
Maximum brightness possible for the LED Maximum brightness possible for the LED
$ref: /schemas/types.yaml#/definitions/uint32 $ref: /schemas/types.yaml#/definitions/uint32
active-low:
description:
For PWMs where the LED is wired to supply rather than ground.
type: boolean
required: required:
- pwms - pwms
- max-brightness - max-brightness
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment