Commit c96e8483 authored by Kirill A. Shutemov's avatar Kirill A. Shutemov Committed by Thomas Gleixner

x86/boot/compressed/64: Fix missing initialization in find_trampoline_placement()

Gustavo noticed that 'new' can be left uninitialized if 'bios_start'
happens to be less or equal to 'entry->addr + entry->size'.

Initialize the variable at the begin of the iteration to the current value
of 'bios_start'.

Fixes: 0a46fff2 ("x86/boot/compressed/64: Fix boot on machines with broken E820 table")
Reported-by: default avatar"Gustavo A. R. Silva" <gustavo@embeddedor.com>
Signed-off-by: default avatarKirill A. Shutemov <kirill.shutemov@linux.intel.com>
Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Link: https://lkml.kernel.org/r/20190826133326.7cxb4vbmiawffv2r@box
parent 558682b5
...@@ -72,7 +72,7 @@ static unsigned long find_trampoline_placement(void) ...@@ -72,7 +72,7 @@ static unsigned long find_trampoline_placement(void)
/* Find the first usable memory region under bios_start. */ /* Find the first usable memory region under bios_start. */
for (i = boot_params->e820_entries - 1; i >= 0; i--) { for (i = boot_params->e820_entries - 1; i >= 0; i--) {
unsigned long new; unsigned long new = bios_start;
entry = &boot_params->e820_table[i]; entry = &boot_params->e820_table[i];
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment