Commit c9710525 authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman

ALSA: ak4xx-adda: info leak in ak4xxx_capture_source_info()

commit bd5fe738 upstream.

"idx" is controled by the user and can be a negative offset into the
input_names[] array.
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
Signed-off-by: default avatarBen Hutchings <ben@decadent.org.uk>
Cc: Weng Meiling <wengmeiling.weng@huawei.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 775a5ddc
...@@ -571,7 +571,7 @@ static int ak4xxx_capture_source_info(struct snd_kcontrol *kcontrol, ...@@ -571,7 +571,7 @@ static int ak4xxx_capture_source_info(struct snd_kcontrol *kcontrol,
struct snd_akm4xxx *ak = snd_kcontrol_chip(kcontrol); struct snd_akm4xxx *ak = snd_kcontrol_chip(kcontrol);
int mixer_ch = AK_GET_SHIFT(kcontrol->private_value); int mixer_ch = AK_GET_SHIFT(kcontrol->private_value);
const char **input_names; const char **input_names;
int num_names, idx; unsigned int num_names, idx;
num_names = ak4xxx_capture_num_inputs(ak, mixer_ch); num_names = ak4xxx_capture_num_inputs(ak, mixer_ch);
if (!num_names) if (!num_names)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment