Commit c9f19b67 authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by Juergen Gross

xen: mark expected switch fall-through

In preparation to enabling -Wimplicit-fallthrough, mark switch
cases where we are expecting to fall through.

This patch fixes the following warning:

drivers/xen/xen-pciback/xenbus.c: In function ‘xen_pcibk_frontend_changed’:
drivers/xen/xen-pciback/xenbus.c:545:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
   if (xenbus_dev_is_online(xdev))
      ^
drivers/xen/xen-pciback/xenbus.c:548:2: note: here
  case XenbusStateUnknown:
  ^~~~

Warning level 3 was used: -Wimplicit-fallthrough=3

Notice that, in this particular case, the code comment is modified
in accordance with what GCC is expecting to find.

This patch is part of the ongoing efforts to enable
-Wimplicit-fallthrough.
Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: default avatarJuergen Gross <jgross@suse.com>
parent a3b22b9f
...@@ -544,7 +544,7 @@ static void xen_pcibk_frontend_changed(struct xenbus_device *xdev, ...@@ -544,7 +544,7 @@ static void xen_pcibk_frontend_changed(struct xenbus_device *xdev,
xenbus_switch_state(xdev, XenbusStateClosed); xenbus_switch_state(xdev, XenbusStateClosed);
if (xenbus_dev_is_online(xdev)) if (xenbus_dev_is_online(xdev))
break; break;
/* fall through if not online */ /* fall through - if not online */
case XenbusStateUnknown: case XenbusStateUnknown:
dev_dbg(&xdev->dev, "frontend is gone! unregister device\n"); dev_dbg(&xdev->dev, "frontend is gone! unregister device\n");
device_unregister(&xdev->dev); device_unregister(&xdev->dev);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment