Commit ca3ffcbe authored by Rob Clark's avatar Rob Clark

drm/msm/gpu: Don't allow zero fence_id

Elsewhere we treat zero as "no fence" and __msm_gem_submit_destroy()
skips removal from fence_idr.  We could alternately change this to use
negative values for "no fence" but I think it is more clear to not allow
zero as a valid fence_id.
Signed-off-by: default avatarRob Clark <robdclark@chromium.org>
Fixes: a61acbbe ("drm/msm: Track "seqno" fences by idr")
Link: https://lore.kernel.org/r/20211129182344.292609-1-robdclark@gmail.comSigned-off-by: default avatarRob Clark <robdclark@chromium.org>
parent b9c8accb
...@@ -881,7 +881,7 @@ int msm_ioctl_gem_submit(struct drm_device *dev, void *data, ...@@ -881,7 +881,7 @@ int msm_ioctl_gem_submit(struct drm_device *dev, void *data,
* to the underlying fence. * to the underlying fence.
*/ */
submit->fence_id = idr_alloc_cyclic(&queue->fence_idr, submit->fence_id = idr_alloc_cyclic(&queue->fence_idr,
submit->user_fence, 0, INT_MAX, GFP_KERNEL); submit->user_fence, 1, INT_MAX, GFP_KERNEL);
if (submit->fence_id < 0) { if (submit->fence_id < 0) {
ret = submit->fence_id = 0; ret = submit->fence_id = 0;
submit->fence_id = 0; submit->fence_id = 0;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment