Commit ca4b32bb authored by Luben Tuikov's avatar Luben Tuikov Committed by Alex Deucher

drm/amd/pm: Add debug prints

Add prints where there are none and none are printed in the callee.

Remove the word "previous" from comment and print to make it shorter and
avoid confusion in various prints.

Cc: Alex Deucher <Alexander.Deucher@amd.com>
Signed-off-by: default avatarLuben Tuikov <luben.tuikov@amd.com>
Reviewed-by: default avatarAlex Deucher <Alexander.Deucher@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 1223c15c
...@@ -1153,6 +1153,8 @@ static int smu_smc_hw_setup(struct smu_context *smu) ...@@ -1153,6 +1153,8 @@ static int smu_smc_hw_setup(struct smu_context *smu)
case IP_VERSION(11, 5, 0): case IP_VERSION(11, 5, 0):
case IP_VERSION(11, 0, 12): case IP_VERSION(11, 0, 12):
ret = smu_system_features_control(smu, true); ret = smu_system_features_control(smu, true);
if (ret)
dev_err(adev->dev, "Failed system features control!\n");
break; break;
default: default:
break; break;
...@@ -1277,8 +1279,10 @@ static int smu_smc_hw_setup(struct smu_context *smu) ...@@ -1277,8 +1279,10 @@ static int smu_smc_hw_setup(struct smu_context *smu)
} }
ret = smu_notify_display_change(smu); ret = smu_notify_display_change(smu);
if (ret) if (ret) {
dev_err(adev->dev, "Failed to notify display change!\n");
return ret; return ret;
}
/* /*
* Set min deep sleep dce fclk with bootup value from vbios via * Set min deep sleep dce fclk with bootup value from vbios via
...@@ -1286,8 +1290,6 @@ static int smu_smc_hw_setup(struct smu_context *smu) ...@@ -1286,8 +1290,6 @@ static int smu_smc_hw_setup(struct smu_context *smu)
*/ */
ret = smu_set_min_dcef_deep_sleep(smu, ret = smu_set_min_dcef_deep_sleep(smu,
smu->smu_table.boot_values.dcefclk / 100); smu->smu_table.boot_values.dcefclk / 100);
if (ret)
return ret;
return ret; return ret;
} }
......
...@@ -97,7 +97,7 @@ static void smu_cmn_read_arg(struct smu_context *smu, ...@@ -97,7 +97,7 @@ static void smu_cmn_read_arg(struct smu_context *smu,
* smu: a pointer to SMU context * smu: a pointer to SMU context
* *
* Returns the status of the SMU, which could be, * Returns the status of the SMU, which could be,
* 0, the SMU is busy with your previous command; * 0, the SMU is busy with your command;
* 1, execution status: success, execution result: success; * 1, execution status: success, execution result: success;
* 0xFF, execution status: success, execution result: failure; * 0xFF, execution status: success, execution result: failure;
* 0xFE, unknown command; * 0xFE, unknown command;
...@@ -143,7 +143,7 @@ static void __smu_cmn_reg_print_error(struct smu_context *smu, ...@@ -143,7 +143,7 @@ static void __smu_cmn_reg_print_error(struct smu_context *smu,
u32 msg_idx = RREG32_SOC15(MP1, 0, mmMP1_SMN_C2PMSG_66); u32 msg_idx = RREG32_SOC15(MP1, 0, mmMP1_SMN_C2PMSG_66);
u32 prm = RREG32_SOC15(MP1, 0, mmMP1_SMN_C2PMSG_82); u32 prm = RREG32_SOC15(MP1, 0, mmMP1_SMN_C2PMSG_82);
dev_err_ratelimited(adev->dev, dev_err_ratelimited(adev->dev,
"SMU: I'm not done with your previous command: SMN_C2PMSG_66:0x%08X SMN_C2PMSG_82:0x%08X", "SMU: I'm not done with your command: SMN_C2PMSG_66:0x%08X SMN_C2PMSG_82:0x%08X",
msg_idx, prm); msg_idx, prm);
} }
break; break;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment