Commit caf08a82 authored by Johan Hovold's avatar Johan Hovold Committed by Linus Walleij

dt-bindings: pinctrl: qcom,pmic-mpp: clean up example

The Multi-Purpose Pin controller block is part of an SPMI PMIC (which in
turns sits on an SPMI bus) and uses a single value for the register
property that corresponds to its base address.

Clean up the example by adding a parent PMIC node with proper
'#address-cells' and '#size-cells' properties, dropping the incorrect
second register value, adding some newline separators and increasing the
indentation to four spaces.
Signed-off-by: default avatarJohan Hovold <johan+linaro@kernel.org>
Reviewed-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://lore.kernel.org/r/20231130172834.12653-1-johan+linaro@kernel.orgSigned-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 7085e4e2
...@@ -158,34 +158,40 @@ examples: ...@@ -158,34 +158,40 @@ examples:
- | - |
#include <dt-bindings/pinctrl/qcom,pmic-mpp.h> #include <dt-bindings/pinctrl/qcom,pmic-mpp.h>
pm8841_mpp: mpps@a000 { pmic {
compatible = "qcom,pm8841-mpp", "qcom,spmi-mpp"; #address-cells = <1>;
reg = <0xa000 0>; #size-cells = <0>;
gpio-controller;
#gpio-cells = <2>; pm8841_mpp: mpps@a000 {
gpio-ranges = <&pm8841_mpp 0 0 4>; compatible = "qcom,pm8841-mpp", "qcom,spmi-mpp";
gpio-line-names = "VDD_PX_BIAS", "WLAN_LED_CTRL", reg = <0xa000>;
"BT_LED_CTRL", "GPIO-F";
interrupt-controller; gpio-controller;
#interrupt-cells = <2>; #gpio-cells = <2>;
gpio-ranges = <&pm8841_mpp 0 0 4>;
pinctrl-names = "default"; gpio-line-names = "VDD_PX_BIAS", "WLAN_LED_CTRL",
pinctrl-0 = <&pm8841_default>; "BT_LED_CTRL", "GPIO-F";
interrupt-controller;
mpp1-state { #interrupt-cells = <2>;
pins = "mpp1";
function = "digital"; pinctrl-names = "default";
input-enable; pinctrl-0 = <&pm8841_default>;
power-source = <PM8841_MPP_S3>;
}; mpp1-state {
pins = "mpp1";
default-state { function = "digital";
gpio-pins { input-enable;
pins = "mpp1", "mpp2", "mpp3", "mpp4"; power-source = <PM8841_MPP_S3>;
function = "digital"; };
input-enable;
power-source = <PM8841_MPP_S3>; default-state {
gpio-pins {
pins = "mpp1", "mpp2", "mpp3", "mpp4";
function = "digital";
input-enable;
power-source = <PM8841_MPP_S3>;
};
};
}; };
};
}; };
... ...
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment