Commit cb323213 authored by Vladis Dronov's avatar Vladis Dronov Committed by Johan Hovold

USB: serial: visor: fix crash on detecting device without write_urbs

The visor driver crashes in clie_5_attach() when a specially crafted USB
device without bulk-out endpoint is detected. This fix adds a check that
the device has proper configuration expected by the driver.
Reported-by: default avatarRalf Spenneberg <ralf@spenneberg.net>
Signed-off-by: default avatarVladis Dronov <vdronov@redhat.com>
Fixes: cfb8da8f ("USB: visor: fix initialisation of UX50/TH55 devices")
Cc: stable <stable@vger.kernel.org>
Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
parent cac9b50b
...@@ -602,8 +602,10 @@ static int clie_5_attach(struct usb_serial *serial) ...@@ -602,8 +602,10 @@ static int clie_5_attach(struct usb_serial *serial)
*/ */
/* some sanity check */ /* some sanity check */
if (serial->num_ports < 2) if (serial->num_bulk_out < 2) {
return -1; dev_err(&serial->interface->dev, "missing bulk out endpoints\n");
return -ENODEV;
}
/* port 0 now uses the modified endpoint Address */ /* port 0 now uses the modified endpoint Address */
port = serial->port[0]; port = serial->port[0];
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment