Commit cb77fcd8 authored by Josef Bacik's avatar Josef Bacik Committed by Chris Mason

Btrfs: delay iput with async extents

There is some concern that these iput()'s could be the final iputs and could
induce lockups on people waiting on writeback.  This would happen in the
rare case that we don't create ordered extents because of an error, but it
is theoretically possible and we already have a mechanism to deal with this
so just make them delayed iputs to negate any worry.
Signed-off-by: default avatarJosef Bacik <josef@redhat.com>
Signed-off-by: default avatarChris Mason <chris.mason@fusionio.com>
parent e18fca73
...@@ -987,7 +987,7 @@ static noinline void async_cow_start(struct btrfs_work *work) ...@@ -987,7 +987,7 @@ static noinline void async_cow_start(struct btrfs_work *work)
async_cow->start, async_cow->end, async_cow, async_cow->start, async_cow->end, async_cow,
&num_added); &num_added);
if (num_added == 0) { if (num_added == 0) {
iput(async_cow->inode); btrfs_add_delayed_iput(async_cow->inode);
async_cow->inode = NULL; async_cow->inode = NULL;
} }
} }
...@@ -1023,7 +1023,7 @@ static noinline void async_cow_free(struct btrfs_work *work) ...@@ -1023,7 +1023,7 @@ static noinline void async_cow_free(struct btrfs_work *work)
struct async_cow *async_cow; struct async_cow *async_cow;
async_cow = container_of(work, struct async_cow, work); async_cow = container_of(work, struct async_cow, work);
if (async_cow->inode) if (async_cow->inode)
iput(async_cow->inode); btrfs_add_delayed_iput(async_cow->inode);
kfree(async_cow); kfree(async_cow);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment